test: fail loudly if EvalSymlinks errors instead of vacuous pass

Address review: discarded EvalSymlinks errors could yield empty paths
and a misleading assertion result on restricted filesystems.

Author: chethanuk

cmd/opencodereview/shared.go

@@ -108,6 +108,9 @@ func resolveWorkingDir(input string, requireGit bool) (string, bool, error) {
 	// requireGit is true only for the review path; scan (requireGit=false) keeps
 	// the CWD so its `git ls-files` walk stays scoped to the subdirectory.
 	if isGit && requireGit {
+		// runGitCmdStdout captures stdout only so git stderr notices can't
+		// pollute the resolved path. absPath is overridden only on success;
+		// on any rev-parse failure it falls back to the caller-provided dir.
 		if top, topErr := runGitCmdStdout(absPath, "rev-parse", "--show-toplevel"); topErr == nil {
 			if t := strings.TrimSpace(string(top)); t != "" {
 				absPath = t

cmd/opencodereview/shared_test.go

@@ -136,7 +136,10 @@ func TestResolveWorkingDir_MonorepoSubdir(t *testing.T) {
 
 	// macOS /var -> /private/var symlink means t.TempDir() differs from the
 	// canonicalized toplevel git returns; compare via EvalSymlinks.
-	wantRoot, _ := filepath.EvalSymlinks(root)
+	wantRoot, err := filepath.EvalSymlinks(root)
+	if err != nil {
+		t.Fatalf("EvalSymlinks(%q): %v", root, err)
+	}
 
 	// review path: hoisted to the git top-level.
 	got, isGit, err := resolveWorkingDir(sub, true)
@@ -146,7 +149,10 @@ func TestResolveWorkingDir_MonorepoSubdir(t *testing.T) {
 	if !isGit {
 		t.Error("expected isGit=true for a git subdirectory")
 	}
-	gotResolved, _ := filepath.EvalSymlinks(got)
+	gotResolved, err := filepath.EvalSymlinks(got)
+	if err != nil {
+		t.Fatalf("EvalSymlinks(%q): %v", got, err)
+	}
 	if gotResolved != wantRoot {
 		t.Errorf("review RepoDir = %q, want git top-level %q", gotResolved, wantRoot)
 	}
@@ -156,8 +162,14 @@ func TestResolveWorkingDir_MonorepoSubdir(t *testing.T) {
 	if err != nil {
 		t.Fatalf("resolveWorkingDir(sub, false) error: %v", err)
 	}
-	gotScanResolved, _ := filepath.EvalSymlinks(gotScan)
-	wantSub, _ := filepath.EvalSymlinks(sub)
+	gotScanResolved, err := filepath.EvalSymlinks(gotScan)
+	if err != nil {
+		t.Fatalf("EvalSymlinks(%q): %v", gotScan, err)
+	}
+	wantSub, err := filepath.EvalSymlinks(sub)
+	if err != nil {
+		t.Fatalf("EvalSymlinks(%q): %v", sub, err)
+	}
 	if gotScanResolved != wantSub {
 		t.Errorf("scan RepoDir = %q, want subdir %q (must stay scoped)", gotScanResolved, wantSub)
 	}