feat(tests): extend type-0 transaction RLP validity tests#2
Open
danceratopz wants to merge 8 commits into
Open
feat(tests): extend type-0 transaction RLP validity tests#2danceratopz wants to merge 8 commits into
danceratopz wants to merge 8 commits into
Conversation
Declare exception lists where clients legitimately report different errors for the same malformed transaction: - `header_declares_less`: the mutation leaves both a truncated final field and a trailing byte at the top level, so clients report it as either an EOF or a size error. - `v_29`: post EIP-155 clients may derive a chain id from any v other than 27 or 28 and reject the mismatch instead of the signature, as already documented in `test_bad_v_r_s`.
The nonce is decoded as a 256-bit scalar by the spec; the 64-bit bound is an EIP-2681 validation rule, not a decoding one. Also note that the signature v is a bounded 256-bit field whose oversized encoding is uncovered only because no field-specific decoding exception exists.
Extend `test_field_as_list` to the signature r and s fields, porting `TRANSCT_rvalue_GivenAsListCopier` and `TRANSCT_svalue_GivenAsListCopier` with the same `RLP_INVALID_SIGNATURE_R`/`_S` exceptions the legacy suite declares. The gas price and v fields remain uncovered for lack of a field-specific decoding exception.
Encode the single-byte nonce payload behind a one-byte string header
(0x8101) instead of as the byte itself. This ports the
`RLPIncorrectByteEncoding{00,01,127}Copier` legacy tests, which corrupt
the nonce this way and declare `RLP_LEADING_ZEROS_NONCE_SIZE`.
Encode the size of the data field's long-form string header with a leading zero byte, porting `RLPArrayLengthWithFirstZerosCopier` with the `RLP_LEADING_ZEROS_DATA_SIZE` exception it declares. This covers the string-header variant of the list-header case already tested by the `list_size_leading_zeros` mutation.
A zero v is well-encoded (empty payload) but is neither 27, 28 nor an EIP-155 value. Declare `INVALID_CHAINID` as an acceptable alternative for the same reason as the other invalid v cases: post EIP-155 clients may derive a chain id from any v other than 27 or 28.
Add `ported_from` references for legacy fillers whose malformation
class is already exercised by an existing case:
- Leading zeros: the `tt{Nonce,GasPrice,GasLimit,Value}` zero-prefixed
fillers and the `TRANSCT_*_Prefixed0000` copiers.
- Overflow: the `TRANSCT_{r,s}value_TooLarge` copiers.
- Address size: `AddressMoreThan20` and the `TRANSCT_to_*` copiers.
- Field as list: the remaining `TRANSCT_*_GivenAsList` copiers.
- Structure: `RLPTransactionGivenAsArray`, matching the
`tx_as_byte_string` mutation.
All referenced fillers were inspected at the pinned commit to confirm
the corruption and declared exception match the covering case.
In execute mode, `pre.fund_eoa()` defers the funding amount until the EOA sends a transaction; an EOA that never sends one fails the run with "Sender balance must be set before sending". The senders of the corrupted transactions never send: only their raw serialization is submitted, expecting rejection. Fund them with `amount=0` so execute mode derives an address without scheduling a funding transaction. The signing keys are derived from the account content, so the corrupted vectors' bytes change; all vectors were re-verified against EELS decoding and validation at Frontier, London and Cancun.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Suggestions on top of ethereum#3156.
header_declares_less(an EOF or a size error) andv_29(post EIP-155 clients may derive a chain id from any v other than 27 or 28, as documented intest_bad_v_r_s).pre.fund_eoa()fails underexecute; withamount=0the whole module now passesexecute hive --fork=Prague(36/36 on besu).randsintest_field_as_list, portingTRANSCT_{r,s}value_GivenAsListCopier.test_non_canonical_single_byte: Single-byte nonce behind a0x81string header, portingRLPIncorrectByteEncoding{00,01,127}Copier.test_data_size_leading_zeros: Long-form data string header with a zero-padded size, portingRLPArrayLengthWithFirstZerosCopier.v_zerointest_invalid_signature_values.