fix(types,e2e): adapt to obsidian 1.13 typings and 1.12.7 protocol registry

- Plugin.settings is now declared on the base class: mark ours override
- DataAdapter.appendBinary is public in API 1.13, but minAppVersion
  predates it, so BinaryAppendAdapter re-declares it optional via Omit
  and keeps the runtime guard
- Obsidian 1.12.7 replaced app.workspace.protocolHandlers (Map) with
  app.workspace.protocolHandler.handlers: e2e harness and tests now
  accept both shapes

Author: chhoumann

src/download/streaming.ts

@@ -43,11 +43,11 @@ function tooLargeError(maxSize: number): Error {
 	);
 }
 
-// Obsidian's DataAdapter — writeBinary/rename/remove/list, all used below — is
-// fully typed and public. Only `appendBinary` exists at runtime on the desktop and
-// mobile Capacitor adapters without appearing in the public typings, so we extend
-// the real interface with that single bolt-on and keep one cast (appendableAdapter).
-export interface BinaryAppendAdapter extends DataAdapter {
+// Obsidian's DataAdapter typings declare `appendBinary` as always present
+// (public since API 1.13), but our minAppVersion predates its availability,
+// so we re-declare it as optional and runtime-guard every call site.
+export interface BinaryAppendAdapter
+	extends Omit<DataAdapter, "appendBinary"> {
 	appendBinary?(path: string, data: ArrayBuffer): Promise<void>;
 }
 
@@ -58,10 +58,9 @@ export interface RangeProbe {
 	totalSize: number | null;
 }
 
-// `appendBinary` exists at runtime on the mobile CapacitorAdapter (and the
-// desktop adapter) but isn't in Obsidian's public DataAdapter typings. Keep the
-// single unsafe cast here so the "where we step outside the types" boundary is
-// greppable in one place.
+// Keep the single unsafe cast here so the "where we step outside the types"
+// boundary is greppable in one place: the cast widens `appendBinary` back to
+// optional for Obsidian runtimes older than API 1.13.
 export function appendableAdapter(): BinaryAppendAdapter {
 	return get(plugin).app.vault.adapter as unknown as BinaryAppendAdapter;
 }

src/main.ts

@@ -65,7 +65,7 @@ type MediaSessionActionName =
 
 export default class PodNotes extends Plugin implements IPodNotes {
 	public api!: IAPI;
-	public settings!: IPodNotesSettings;
+	public override settings!: IPodNotesSettings;
 	public override app!: PartialAppExtension;
 
 	private views = new Set<MainView>();

tests/e2e/harness.ts

@@ -211,7 +211,7 @@ export async function waitForPodNotesReady(
 			return await obsidian.dev.evalJson<boolean>(`
 			Boolean(
 				app.plugins.plugins.${PLUGIN_ID}?.api &&
-				app.workspace.protocolHandlers?.has(${JSON.stringify(PLUGIN_ID)})
+				(app.workspace.protocolHandlers ?? app.workspace.protocolHandler?.handlers)?.has(${JSON.stringify(PLUGIN_ID)})
 			)
 		`);
 		},

tests/e2e/podnotes-runtime.test.ts

@@ -50,7 +50,7 @@ describe("PodNotes runtime", () => {
 					typeof app.commands?.commands?.[${JSON.stringify(`${PLUGIN_ID}:capture-timestamp`)}]?.editorCheckCallback === "function",
 				hasCaptureSegment10Command: Boolean(app.commands?.commands?.[${JSON.stringify(`${PLUGIN_ID}:capture-segment-10s`)}]),
 				hasCaptureSegment20Command: Boolean(app.commands?.commands?.[${JSON.stringify(`${PLUGIN_ID}:capture-segment-20s`)}]),
-				hasProtocolHandler: app.workspace.protocolHandlers?.has(${JSON.stringify(PLUGIN_ID)}) ?? false,
+				hasProtocolHandler: (app.workspace.protocolHandlers ?? app.workspace.protocolHandler?.handlers)?.has(${JSON.stringify(PLUGIN_ID)}) ?? false,
 				hasRateCommands: [
 					${JSON.stringify(`${PLUGIN_ID}:increase-playback-rate`)},
 					${JSON.stringify(`${PLUGIN_ID}:decrease-playback-rate`)},
@@ -623,7 +623,7 @@ async function invokePodNotesUri(
 		obsidian,
 		`
 		(async () => {
-			const handler = app.workspace.protocolHandlers.get(${JSON.stringify(PLUGIN_ID)});
+			const handler = (app.workspace.protocolHandlers ?? app.workspace.protocolHandler?.handlers).get(${JSON.stringify(PLUGIN_ID)});
 			if (!handler) {
 				return { ok: false, error: "PodNotes protocol handler is not registered." };
 			}