Commit ec573eb
authored
feat(templates): add {{currentDate}}, {{episodeNumber}}, {{duration}} template variables (#189)
* feat(templates): add {{currentDate}}, {{episodeNumber}}, {{duration}} tags
- {{currentDate}}: note-creation date, distinct from episode {{date}} (#75)
- {{episodeNumber}}: from <itunes:episode>, best-effort title fallback (#34)
- {{duration}}: from <itunes:duration>, clock/minutes/seconds formats (#88)
Parse episodeNumber/duration in feedParser; add parse/format utilities and
unit tests for the new tags, parser, and utilities.
* fix(templates): harden new template vars after review
- parseEpisodeNumber: fix ReDoS (remove adjacent \s* quantifiers, bound title
prefix); reject decimal-title misreads (10.5) and precision-losing itunes:episode
- parseDuration: reject non-finite/implausible durations (no Infinity), drop dead
length<2 guard, pin non-normalized colon behavior
- TemplateEngine: stop comma-splitting tag args so formats like
{{currentDate:MMMM D, YYYY}} render; extract formatEpisodeNumber to a utility
- FeedCacheService: bump cache key v1->v2 so new fields populate after upgrade
- tests: cover DownloadPath/Transcript engines, duration=0, cache round-trip,
ReDoS regression, numeric guards
- docs: correct duration format support (no bracket escaping), path-tag safety,
episodeNumber fallback wording
* fix(devx): sync E2E provision-vault seed with DEFAULT_SETTINGS
DEFAULT_PODNOTES_DATA had drifted from DEFAULT_SETTINGS (missing autoQueue
and feedNote, stale download.path default from #108/#163/#186), which failed
the drift-guard test in CI and seeded an outdated data.json into E2E vaults.
Bring the seed back in sync so the guard test passes and provisioned vaults
load with current defaults.
* fix(templates): address second-round review findings
- parseEpisodeNumber: also reject decimals after a label marker (Ep 10.5 / #10.5
/ E10.5 no longer parse as 10)
- TemplateEngine: resolve {{episodeNumber}} via a title fallback at render so
persisted/restored episodes (e.g. currentEpisode) still populate it; tighten
TagValue to the single-argument contract
- FeedCacheService: actively delete the superseded v1 cache key on load so a
stale blob can't orphan or exhaust the localStorage quota
- tests: labeled-decimal cases, plausible-duration boundary, formatDuration(0)
and uppercase keyword, {{duration}} unreplaced in download paths, v1 cleanup
- docs: note {{duration}} needs a refetch for pre-upgrade current episodes
* fix(templates): address third-round review (cache clear path, test/doc polish)
- FeedCacheService: also delete legacy keys in clearFeedCache (a clear before
first load would otherwise leave v1 behind); share a removeLegacyCaches helper
- tests: pin episodeNumber=0 at the engine level, {{duration}} unreplaced in
file-path templates, formatDuration sub-hour boundary (3599), v1 clear path
- docs: fuller episode-number title examples, accurate {{duration}} path-engine
exclusion rationale, and a note that feed notes use {{date}} not {{currentDate}}1 parent a8b7a4a commit ec573eb
17 files changed
Lines changed: 752 additions & 14 deletions
File tree
- docs/docs
- scripts
- src
- parser
- services
- types
- utility
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| 15 | + | |
| 16 | + | |
15 | 17 | | |
16 | | - | |
17 | | - | |
| 18 | + | |
18 | 19 | | |
19 | 20 | | |
20 | 21 | | |
| |||
30 | 31 | | |
31 | 32 | | |
32 | 33 | | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
33 | 42 | | |
34 | 43 | | |
35 | 44 | | |
| |||
70 | 79 | | |
71 | 80 | | |
72 | 81 | | |
73 | | - | |
| 82 | + | |
74 | 83 | | |
75 | 84 | | |
76 | 85 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
| 45 | + | |
45 | 46 | | |
46 | 47 | | |
47 | 48 | | |
| |||
53 | 54 | | |
54 | 55 | | |
55 | 56 | | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
56 | 74 | | |
57 | | - | |
| 75 | + | |
58 | 76 | | |
59 | 77 | | |
60 | 78 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| 6 | + | |
6 | 7 | | |
| 8 | + | |
7 | 9 | | |
8 | 10 | | |
9 | 11 | | |
| |||
222 | 224 | | |
223 | 225 | | |
224 | 226 | | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
| 331 | + | |
| 332 | + | |
| 333 | + | |
| 334 | + | |
| 335 | + | |
| 336 | + | |
| 337 | + | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
| 344 | + | |
| 345 | + | |
| 346 | + | |
| 347 | + | |
| 348 | + | |
| 349 | + | |
| 350 | + | |
| 351 | + | |
| 352 | + | |
| 353 | + | |
| 354 | + | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
| 358 | + | |
| 359 | + | |
| 360 | + | |
| 361 | + | |
| 362 | + | |
| 363 | + | |
| 364 | + | |
| 365 | + | |
| 366 | + | |
| 367 | + | |
| 368 | + | |
| 369 | + | |
| 370 | + | |
| 371 | + | |
| 372 | + | |
| 373 | + | |
| 374 | + | |
| 375 | + | |
| 376 | + | |
| 377 | + | |
| 378 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
9 | 12 | | |
10 | | - | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
11 | 17 | | |
12 | 18 | | |
13 | 19 | | |
| |||
53 | 59 | | |
54 | 60 | | |
55 | 61 | | |
56 | | - | |
57 | | - | |
58 | | - | |
59 | | - | |
60 | | - | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
61 | 67 | | |
62 | 68 | | |
63 | 69 | | |
| |||
71 | 77 | | |
72 | 78 | | |
73 | 79 | | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
74 | 90 | | |
75 | 91 | | |
76 | 92 | | |
| |||
108 | 124 | | |
109 | 125 | | |
110 | 126 | | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
111 | 142 | | |
112 | 143 | | |
113 | 144 | | |
| |||
171 | 202 | | |
172 | 203 | | |
173 | 204 | | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
174 | 211 | | |
175 | 212 | | |
176 | 213 | | |
| |||
207 | 244 | | |
208 | 245 | | |
209 | 246 | | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
210 | 253 | | |
211 | 254 | | |
212 | 255 | | |
| |||
239 | 282 | | |
240 | 283 | | |
241 | 284 | | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
242 | 296 | | |
243 | 297 | | |
244 | 298 | | |
| |||
0 commit comments