fix(release): verify recovery attestation source#261
Merged
Conversation
Deploying podnotes with
|
| Latest commit: |
2497033
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://682227a9.podnotes.pages.dev |
| Branch Preview URL: | https://fix-release-recovery-attesta.podnotes.pages.dev |
chhoumann
marked this pull request as ready for review
July 10, 2026 08:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Failure reproduced
Recovery run 29079826974 correctly used the reviewed workflow from
refs/heads/masterwhile rebuilding release commit79c6421334caae9c9ec3fa97620e49ae2dad95c9. The attestation verifier still required the release commit as its source digest, so it selected the earlierrelease-run/2.17.4attestation and rejected the master source ref before publication.Validation
git diff --checknpm run format:check.github/workflows/release.ymlnpm run test -- scripts/release-contract.test.ts scripts/release-plan.test.ts(28 tests)Recovery
After merge, rerun
release.ymlfrom protected master for release PR #259. The verifier will bind attestations to the exact reviewed master workflow commit while the release payload and tag remain bound to the original 2.17.4 merge commit.