Skip to content

ci(release): verify published metadata #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chhoumann merged 1 commit into from
Jul 10, 2026
Merged

ci(release): verify published metadata #264

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -646,6 +646,17 @@ jobs:
}
}

function assertPublishedReleaseMetadata(candidate) {
if (candidate.draft !== false ||
candidate.prerelease !== false ||
candidate.tag_name !== version ||
candidate.target_commitish !== releaseSha ||
candidate.name !== version ||
candidate.body !== notes) {
throw new Error(`Published release ${version} metadata or target does not match.`);
}
}

async function waitForPublishedRelease(releaseId) {
for (let attempt = 0; attempt < 30; attempt += 1) {
const current = await github.rest.repos.getRelease({
Expand Down Expand Up @@ -740,9 +751,7 @@ jobs:
}

if (!release.draft) {
if (release.name !== version || release.body !== notes || release.prerelease) {
throw new Error(`Published release ${version} metadata does not match.`);
}
assertPublishedReleaseMetadata(release);
await verifyRemoteAssets(release.id);
if (await resolveTagCommit(version) !== releaseSha) {
throw new Error(`Published release tag ${version} changed during verification.`);
Expand Down Expand Up @@ -804,6 +813,7 @@ jobs:
make_latest: 'true',
});
release = await waitForPublishedRelease(release.id);
assertPublishedReleaseMetadata(release);
if (await resolveTagCommit(version) !== releaseSha) {
throw new Error(`Release tag ${version} changed during publication.`);
}
Expand Down