refactor(advanced-settings-dialog): extract __init__ into smaller methods to fix R0914 (#1538)

Co-authored-by: Raivis Dejus <raivisd@scandiweb.com>

Author: josiasdev

buzz/widgets/transcriber/advanced_settings_dialog.py

@@ -50,13 +50,20 @@ def __init__(
         layout = QFormLayout(self)
         layout.setFieldGrowthPolicy(QFormLayout.FieldGrowthPolicy.ExpandingFieldsGrow)
 
-        transcription_settings_title= _("Speech recognition settings")
+        self._setup_transcription_section(layout)
+        self._setup_translation_section(layout)
+        if show_recording_settings:
+            self._setup_recording_section(layout)
+        self._setup_button_box(layout)
+
+    def _setup_transcription_section(self, layout: QFormLayout):
+        transcription_settings_title = _("Speech recognition settings")
         transcription_settings_title_label = QLabel(f"<h4>{transcription_settings_title}</h4>", self)
         layout.addRow("", transcription_settings_title_label)
 
         self.initial_prompt_text_edit = InitialPromptTextEdit(
-            transcription_options.initial_prompt,
-            transcription_options.model.model_type,
+            self.transcription_options.initial_prompt,
+            self.transcription_options.model.model_type,
             self,
         )
         self.initial_prompt_text_edit.textChanged.connect(
@@ -65,7 +72,8 @@ def __init__(
 
         layout.addRow(_("Initial Prompt:"), self.initial_prompt_text_edit)
 
-        translation_settings_title= _("Translation settings")
+    def _setup_translation_section(self, layout: QFormLayout):
+        translation_settings_title = _("Translation settings")
         translation_settings_title_label = QLabel(f"<h4>{translation_settings_title}</h4>", self)
         layout.addRow("", translation_settings_title_label)
 
@@ -112,140 +120,141 @@ def __init__(
         self.llm_prompt_label.setEnabled(self.transcription_options.enable_llm_translation)
         layout.addRow(self.llm_prompt_label, self.llm_prompt_text_edit)
 
-        if show_recording_settings:
-            recording_settings_title = _("Recording settings")
-            recording_settings_title_label = QLabel(f"<h4>{recording_settings_title}</h4>", self)
-            layout.addRow("", recording_settings_title_label)
-
-            self.silence_threshold_spin_box = QDoubleSpinBox(self)
-            self.silence_threshold_spin_box.setRange(0.0, 1.0)
-            self.silence_threshold_spin_box.setSingleStep(0.0005)
-            self.silence_threshold_spin_box.setDecimals(4)
-            self.silence_threshold_spin_box.setValue(transcription_options.silence_threshold)
-            self.silence_threshold_spin_box.valueChanged.connect(self.on_silence_threshold_changed)
-            self.silence_threshold_spin_box.setFixedWidth(90)
-            layout.addRow(_("Silence threshold:"), self.silence_threshold_spin_box)
-
-            # Live recording mode
-            self.recording_mode_combo = QComboBox(self)
-            for mode in RecordingTranscriberMode:
-                self.recording_mode_combo.addItem(mode.value)
-            self.recording_mode_combo.setCurrentIndex(
-                self.settings.value(Settings.Key.RECORDING_TRANSCRIBER_MODE, 0)
-            )
-            self.recording_mode_combo.currentIndexChanged.connect(self.on_recording_mode_changed)
-            self.recording_mode_combo.setFixedWidth(250)
-            layout.addRow(_("Live recording mode") + ":", self.recording_mode_combo)
-
-            self.line_separator_line_edit = QLineEdit(self)
-            line_sep_display = repr(transcription_options.line_separator)[1:-1] or r"\n\n"
-            self.line_separator_line_edit.setText(line_sep_display)
-            self.line_separator_line_edit.textChanged.connect(self.on_line_separator_changed)
-            self.line_separator_label = QLabel(_("Line separator:"))
-            layout.addRow(self.line_separator_label, self.line_separator_line_edit)
-
-            self.transcription_step_spin_box = QDoubleSpinBox(self)
-            self.transcription_step_spin_box.setRange(2.0, 5.0)
-            self.transcription_step_spin_box.setSingleStep(0.1)
-            self.transcription_step_spin_box.setDecimals(1)
-            self.transcription_step_spin_box.setValue(transcription_options.transcription_step)
-            self.transcription_step_spin_box.valueChanged.connect(self.on_transcription_step_changed)
-            self.transcription_step_spin_box.setFixedWidth(80)
-            self.transcription_step_label = QLabel(_("Transcription step:"))
-            layout.addRow(self.transcription_step_label, self.transcription_step_spin_box)
-
-            hide_unconfirmed = self.settings.value(
-                Settings.Key.RECORDING_TRANSCRIBER_HIDE_UNCONFIRMED, True
-            )
-            self.hide_unconfirmed_checkbox = QCheckBox(_("Hide unconfirmed"))
-            self.hide_unconfirmed_checkbox.setChecked(hide_unconfirmed)
-            self.hide_unconfirmed_checkbox.stateChanged.connect(self.on_hide_unconfirmed_changed)
-            self.hide_unconfirmed_label = QLabel("")
-            layout.addRow(self.hide_unconfirmed_label, self.hide_unconfirmed_checkbox)
-
-            self._update_recording_mode_visibility(
-                RecordingTranscriberMode(self.recording_mode_combo.currentText())
-            )
-
-            # Export enabled checkbox
-            self._export_enabled = self.settings.value(
-                Settings.Key.RECORDING_TRANSCRIBER_EXPORT_ENABLED, False
-            )
-            self.export_enabled_checkbox = QCheckBox(_("Enable live recording export"))
-            self.export_enabled_checkbox.setChecked(self._export_enabled)
-            self.export_enabled_checkbox.stateChanged.connect(self.on_export_enabled_changed)
-            layout.addRow("", self.export_enabled_checkbox)
-
-            # Export folder
-            export_folder = self.settings.value(
-                Settings.Key.RECORDING_TRANSCRIBER_EXPORT_FOLDER, ""
-            )
-            self.export_folder_line_edit = LineEdit(export_folder, self)
-            self.export_folder_line_edit.setEnabled(self._export_enabled)
-            self.export_folder_line_edit.textChanged.connect(self.on_export_folder_changed)
-            self.export_folder_browse_button = QPushButton(_("Browse"), self)
-            self.export_folder_browse_button.setEnabled(self._export_enabled)
-            self.export_folder_browse_button.clicked.connect(self.on_browse_export_folder)
-            export_folder_row = QHBoxLayout()
-            export_folder_row.addWidget(self.export_folder_line_edit)
-            export_folder_row.addWidget(self.export_folder_browse_button)
-            self.export_folder_label = QLabel(_("Export folder:"))
-            self.export_folder_label.setEnabled(self._export_enabled)
-            layout.addRow(self.export_folder_label, export_folder_row)
-
-            # Export file name template
-            export_file_name = self.settings.value(
-                Settings.Key.RECORDING_TRANSCRIBER_EXPORT_FILE_NAME, ""
-            )
-            self.export_file_name_line_edit = LineEdit(export_file_name, self)
-            self.export_file_name_line_edit.setEnabled(self._export_enabled)
-            self.export_file_name_line_edit.textChanged.connect(self.on_export_file_name_changed)
-            self.export_file_name_label = QLabel(_("Export file name:"))
-            self.export_file_name_label.setEnabled(self._export_enabled)
-            layout.addRow(self.export_file_name_label, self.export_file_name_line_edit)
-
-            # Export file type
-            self.export_file_type_combo = QComboBox(self)
-            self.export_file_type_combo.addItem(_("Text file (.txt)"), "txt")
-            self.export_file_type_combo.addItem(_("CSV (.csv)"), "csv")
-            current_type = self.settings.value(
-                Settings.Key.RECORDING_TRANSCRIBER_EXPORT_FILE_TYPE, "txt"
-            )
-            type_index = self.export_file_type_combo.findData(current_type)
-            if type_index >= 0:
-                self.export_file_type_combo.setCurrentIndex(type_index)
-            self.export_file_type_combo.setEnabled(self._export_enabled)
-            self.export_file_type_combo.currentIndexChanged.connect(self.on_export_file_type_changed)
-            self.export_file_type_combo.setFixedWidth(200)
-            self.export_file_type_label = QLabel(_("Export file type:"))
-            self.export_file_type_label.setEnabled(self._export_enabled)
-            layout.addRow(self.export_file_type_label, self.export_file_type_combo)
-
-            # Max entries
-            max_entries = self.settings.value(
-                Settings.Key.RECORDING_TRANSCRIBER_EXPORT_MAX_ENTRIES, 0, int
-            )
-            self.export_max_entries_spin = QSpinBox(self)
-            self.export_max_entries_spin.setRange(0, 99)
-            self.export_max_entries_spin.setValue(max_entries)
-            self.export_max_entries_spin.setEnabled(self._export_enabled)
-            self.export_max_entries_spin.valueChanged.connect(self.on_export_max_entries_changed)
-            self.export_max_entries_spin.setFixedWidth(90)
-            self.export_max_entries_label = QLabel(_("Limit export entries\n(0 = export all):"))
-            self.export_max_entries_label.setEnabled(self._export_enabled)
-            layout.addRow(self.export_max_entries_label, self.export_max_entries_spin)
-
-            _field_height = self.llm_model_line_edit.sizeHint().height()
-            for widget in (
-                self.line_separator_line_edit,
-                self.silence_threshold_spin_box,
-                self.recording_mode_combo,
-                self.transcription_step_spin_box,
-                self.export_file_type_combo,
-                self.export_max_entries_spin,
-            ):
-                widget.setFixedHeight(_field_height)
+    def _setup_recording_section(self, layout: QFormLayout):
+        recording_settings_title = _("Recording settings")
+        recording_settings_title_label = QLabel(f"<h4>{recording_settings_title}</h4>", self)
+        layout.addRow("", recording_settings_title_label)
+
+        self.silence_threshold_spin_box = QDoubleSpinBox(self)
+        self.silence_threshold_spin_box.setRange(0.0, 1.0)
+        self.silence_threshold_spin_box.setSingleStep(0.0005)
+        self.silence_threshold_spin_box.setDecimals(4)
+        self.silence_threshold_spin_box.setValue(self.transcription_options.silence_threshold)
+        self.silence_threshold_spin_box.valueChanged.connect(self.on_silence_threshold_changed)
+        self.silence_threshold_spin_box.setFixedWidth(90)
+        layout.addRow(_("Silence threshold:"), self.silence_threshold_spin_box)
+
+        # Live recording mode
+        self.recording_mode_combo = QComboBox(self)
+        for mode in RecordingTranscriberMode:
+            self.recording_mode_combo.addItem(mode.value)
+        self.recording_mode_combo.setCurrentIndex(
+            self.settings.value(Settings.Key.RECORDING_TRANSCRIBER_MODE, 0)
+        )
+        self.recording_mode_combo.currentIndexChanged.connect(self.on_recording_mode_changed)
+        self.recording_mode_combo.setFixedWidth(250)
+        layout.addRow(_("Live recording mode") + ":", self.recording_mode_combo)
+
+        self.line_separator_line_edit = QLineEdit(self)
+        line_sep_display = repr(self.transcription_options.line_separator)[1:-1] or r"\n\n"
+        self.line_separator_line_edit.setText(line_sep_display)
+        self.line_separator_line_edit.textChanged.connect(self.on_line_separator_changed)
+        self.line_separator_label = QLabel(_("Line separator:"))
+        layout.addRow(self.line_separator_label, self.line_separator_line_edit)
+
+        self.transcription_step_spin_box = QDoubleSpinBox(self)
+        self.transcription_step_spin_box.setRange(2.0, 5.0)
+        self.transcription_step_spin_box.setSingleStep(0.1)
+        self.transcription_step_spin_box.setDecimals(1)
+        self.transcription_step_spin_box.setValue(self.transcription_options.transcription_step)
+        self.transcription_step_spin_box.valueChanged.connect(self.on_transcription_step_changed)
+        self.transcription_step_spin_box.setFixedWidth(80)
+        self.transcription_step_label = QLabel(_("Transcription step:"))
+        layout.addRow(self.transcription_step_label, self.transcription_step_spin_box)
+
+        hide_unconfirmed = self.settings.value(
+            Settings.Key.RECORDING_TRANSCRIBER_HIDE_UNCONFIRMED, True
+        )
+        self.hide_unconfirmed_checkbox = QCheckBox(_("Hide unconfirmed"))
+        self.hide_unconfirmed_checkbox.setChecked(hide_unconfirmed)
+        self.hide_unconfirmed_checkbox.stateChanged.connect(self.on_hide_unconfirmed_changed)
+        self.hide_unconfirmed_label = QLabel("")
+        layout.addRow(self.hide_unconfirmed_label, self.hide_unconfirmed_checkbox)
+
+        self._update_recording_mode_visibility(
+            RecordingTranscriberMode(self.recording_mode_combo.currentText())
+        )
 
+        # Export enabled checkbox
+        self._export_enabled = self.settings.value(
+            Settings.Key.RECORDING_TRANSCRIBER_EXPORT_ENABLED, False
+        )
+        self.export_enabled_checkbox = QCheckBox(_("Enable live recording export"))
+        self.export_enabled_checkbox.setChecked(self._export_enabled)
+        self.export_enabled_checkbox.stateChanged.connect(self.on_export_enabled_changed)
+        layout.addRow("", self.export_enabled_checkbox)
+
+        # Export folder
+        export_folder = self.settings.value(
+            Settings.Key.RECORDING_TRANSCRIBER_EXPORT_FOLDER, ""
+        )
+        self.export_folder_line_edit = LineEdit(export_folder, self)
+        self.export_folder_line_edit.setEnabled(self._export_enabled)
+        self.export_folder_line_edit.textChanged.connect(self.on_export_folder_changed)
+        self.export_folder_browse_button = QPushButton(_("Browse"), self)
+        self.export_folder_browse_button.setEnabled(self._export_enabled)
+        self.export_folder_browse_button.clicked.connect(self.on_browse_export_folder)
+        export_folder_row = QHBoxLayout()
+        export_folder_row.addWidget(self.export_folder_line_edit)
+        export_folder_row.addWidget(self.export_folder_browse_button)
+        self.export_folder_label = QLabel(_("Export folder:"))
+        self.export_folder_label.setEnabled(self._export_enabled)
+        layout.addRow(self.export_folder_label, export_folder_row)
+
+        # Export file name template
+        export_file_name = self.settings.value(
+            Settings.Key.RECORDING_TRANSCRIBER_EXPORT_FILE_NAME, ""
+        )
+        self.export_file_name_line_edit = LineEdit(export_file_name, self)
+        self.export_file_name_line_edit.setEnabled(self._export_enabled)
+        self.export_file_name_line_edit.textChanged.connect(self.on_export_file_name_changed)
+        self.export_file_name_label = QLabel(_("Export file name:"))
+        self.export_file_name_label.setEnabled(self._export_enabled)
+        layout.addRow(self.export_file_name_label, self.export_file_name_line_edit)
+
+        # Export file type
+        self.export_file_type_combo = QComboBox(self)
+        self.export_file_type_combo.addItem(_("Text file (.txt)"), "txt")
+        self.export_file_type_combo.addItem(_("CSV (.csv)"), "csv")
+        current_type = self.settings.value(
+            Settings.Key.RECORDING_TRANSCRIBER_EXPORT_FILE_TYPE, "txt"
+        )
+        type_index = self.export_file_type_combo.findData(current_type)
+        if type_index >= 0:
+            self.export_file_type_combo.setCurrentIndex(type_index)
+        self.export_file_type_combo.setEnabled(self._export_enabled)
+        self.export_file_type_combo.currentIndexChanged.connect(self.on_export_file_type_changed)
+        self.export_file_type_combo.setFixedWidth(200)
+        self.export_file_type_label = QLabel(_("Export file type:"))
+        self.export_file_type_label.setEnabled(self._export_enabled)
+        layout.addRow(self.export_file_type_label, self.export_file_type_combo)
+
+        # Max entries
+        max_entries = self.settings.value(
+            Settings.Key.RECORDING_TRANSCRIBER_EXPORT_MAX_ENTRIES, 0, int
+        )
+        self.export_max_entries_spin = QSpinBox(self)
+        self.export_max_entries_spin.setRange(0, 99)
+        self.export_max_entries_spin.setValue(max_entries)
+        self.export_max_entries_spin.setEnabled(self._export_enabled)
+        self.export_max_entries_spin.valueChanged.connect(self.on_export_max_entries_changed)
+        self.export_max_entries_spin.setFixedWidth(90)
+        self.export_max_entries_label = QLabel(_("Limit export entries\n(0 = export all):"))
+        self.export_max_entries_label.setEnabled(self._export_enabled)
+        layout.addRow(self.export_max_entries_label, self.export_max_entries_spin)
+
+        _field_height = self.llm_model_line_edit.sizeHint().height()
+        for widget in (
+            self.line_separator_line_edit,
+            self.silence_threshold_spin_box,
+            self.recording_mode_combo,
+            self.transcription_step_spin_box,
+            self.export_file_type_combo,
+            self.export_max_entries_spin,
+        ):
+            widget.setFixedHeight(_field_height)
+
+    def _setup_button_box(self, layout: QFormLayout):
         button_box = QDialogButtonBox(
             QDialogButtonBox.StandardButton(QDialogButtonBox.StandardButton.Ok), self
         )
@@ -254,8 +263,6 @@ def __init__(
 
         layout.addWidget(button_box)
 
-        self.setLayout(layout)
-
     def on_initial_prompt_changed(self):
         self.transcription_options.initial_prompt = (
             self.initial_prompt_text_edit.toPlainText()