Fix folder watcher duplicate filename handling#1556
Merged
Conversation
honma89
commented
Jul 16, 2026
honma89
left a comment
Contributor
Author
There was a problem hiding this comment.
Hello. I've addressed the duplicate filename issue by generating a unique filename whenever a conflict is detected. Appreciate it, if you could review the changes.
Collaborator
|
@honma89 Thanks for the contribution |
raivisdejus
enabled auto-merge (squash)
July 17, 2026 07:28
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1556 +/- ##
==========================================
+ Coverage 82.91% 82.95% +0.04%
==========================================
Files 108 108
Lines 11697 11697
==========================================
+ Hits 9698 9703 +5
+ Misses 1999 1994 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Fix duplicate filename handling in the folder watcher.
Previously, the folder watcher only tracked processed files by their path. If a new file was created with the same filename as a previously processed file, it could be skipped because Buzz considered it already handled.
This change updates the tracking logic to store the file's size and modification time along with the path, so Buzz can distinguish between the same file and a new version of a file with the same name.
Changes
Prevent duplicate output filenames
Before creating the output file, the code now checks whether the target filename already exists. If it does, a numeric suffix is appended until an available filename is found.
The output path is then used instead of overwriting the existing file.
Result
audio.mp3audio (1).mp3audio (2).mp3