Skip to content

Commit f4db934

Browse files
committed
Replace FIXME for flags value in ExponentialHistogram aggregation
1 parent f2c6757 commit f4db934

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

  • opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal

opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/aggregation.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -887,7 +887,8 @@ def collect(
887887
offset=value_negative.offset,
888888
bucket_counts=(value_negative.get_offset_counts()),
889889
),
890-
# FIXME: Find the right value for flags
890+
# This data point has recorded values, so no flags are set.
891+
# If no value was recorded, None is returned instead.
891892
flags=0,
892893
min=min_,
893894
max=max_,
@@ -1055,7 +1056,8 @@ def collect(
10551056
self._previous_value_negative.get_offset_counts()
10561057
),
10571058
),
1058-
# FIXME: Find the right value for flags
1059+
# This data point has recorded values, so no flags are set.
1060+
# If no value was recorded, empty Buckets() are used instead.
10591061
flags=0,
10601062
min=self._previous_min,
10611063
max=self._previous_max,

0 commit comments

Comments
 (0)