Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 57 additions & 0 deletions test/e2e/http-proxy-middleware.spec.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import { Agent as HttpAgent } from 'node:http';

import bodyParser from 'body-parser';
import type * as express from 'express';
import type { CompletedRequest, Mockttp } from 'mockttp';
Expand Down Expand Up @@ -488,6 +490,61 @@ describe('E2E http-proxy-middleware', () => {

expect(completedRequest?.headers['x-added']).toBe('added-from-hpm');
});

it('should keep header mutation safe under keep-alive socket contention (#472)', async () => {
const upstreamAgent = new HttpAgent({
keepAlive: true,
maxSockets: 1,
maxFreeSockets: 1,
});
const completedRequests: CompletedRequest[] = [];
const proxyErrors: Error[] = [];

agent = request(
createApp(
createProxyMiddleware({
target: mockTargetServer.url,
pathFilter: '/api',
agent: upstreamAgent,
on: {
proxyReq: (proxyReq) => {
proxyReq.setHeader('x-added', 'added-from-hpm');
},
error: (error, req, res) => {
proxyErrors.push(error);

if ('headersSent' in res && 'writeHead' in res && !res.headersSent) {
res.writeHead(500);
res.end('proxy error');
}
},
},
}),
),
);

await mockTargetServer.forGet('/api/socket-contention').thenCallback(async (req) => {
completedRequests.push(req);
await new Promise((resolve) => setTimeout(resolve, 50));

return { statusCode: 200, body: 'OK' };
});

try {
const responses = await Promise.all(
Array.from({ length: 20 }, () => agent.get('/api/socket-contention').expect(200)),
);

expect(responses).toHaveLength(20);
expect(proxyErrors).toEqual([]);
expect(completedRequests).toHaveLength(20);
expect(
completedRequests.every((req) => req.headers['x-added'] === 'added-from-hpm'),
).toBe(true);
} finally {
upstreamAgent.destroy();
}
}, 15000);
});

describe('option.pathRewrite', () => {
Expand Down
Loading