BUG/MINOR: startup: handle a possible strdup() failure

Egor Shestakov · wtarreau · commit 2a07dc9c24b8 · 2026-02-06T10:50:31.000+01:00
Fix unhandled strdup() failure when initializing global.log_tag. Bug was introduced with the fix UAF for global progname pointer from 351ae5d. So it must be backported as far as 3.1.
diff --git a/src/haproxy.c b/src/haproxy.c
@@ -1441,6 +1441,10 @@ static void init_early(int argc, char **argv)
 	}
 
 	chunk_initlen(&global.log_tag, strdup(progname), len, len);
+	if (b_orig(&global.log_tag) == NULL) {
+		ha_alert("Cannot allocate memory for log_tag.\n");
+		exit(EXIT_FAILURE);
+	}
 }
 
 /* handles program arguments. Very minimal parsing is performed, variables are

Original file line number	Diff line number	Diff line change
`@@ -1441,6 +1441,10 @@ static void init_early(int argc, char **argv)`
`1441`	`1441`	`}`
`1442`	`1442`
`1443`	`1443`	`chunk_initlen(&global.log_tag, strdup(progname), len, len);`
	`1444`	`+ if (b_orig(&global.log_tag) == NULL) {`
	`1445`	`+ ha_alert("Cannot allocate memory for log_tag.\n");`
	`1446`	`+ exit(EXIT_FAILURE);`
	`1447`	`+ }`
`1444`	`1448`	`}`
`1445`	`1449`
`1446`	`1450`	`/* handles program arguments. Very minimal parsing is performed, variables are`