task(RHOAIENG-26590): Report RayJob status via SDK#2
Draft
chipspeak wants to merge 6 commits into
Draft
Conversation
chipspeak
force-pushed
the
RHOAIENG-26590
branch
3 times, most recently
from
1935573 to
8ec2ec8
Compare
Signed-off-by: Pat O'Connor <paoconno@redhat.com>
laurafitzgerald
left a comment
laurafitzgerald
left a comment
Collaborator
There was a problem hiding this comment.
@chipspeak some questions/comments inline. can be addressed elsewhere if needed.
|
|
||
| This class provides a simplified interface for submitting and managing | ||
| Ray jobs in a Kubernetes cluster with the KubeRay operator installed. | ||
| Ray jobs via the Codeflare SDK (using the KubeRay RayJob python client). |
Collaborator
There was a problem hiding this comment.
Suggested change
| Ray jobs via the Codeflare SDK (using the KubeRay RayJob python client). | |
| Rayjob crs (using the KubeRay RayJob python client). |
| # Create table with error message | ||
| table = _create_info_table("[white on red][bold]Name", job_name, "[bold red]No RayJob found") | ||
| table.add_row() | ||
| table.add_row("Have you run rayjob.submit() yet?") |
Collaborator
There was a problem hiding this comment.
Suggested change
| table.add_row("Have you run rayjob.submit() yet?") | |
| table.add_row("Please run rayjob.submit() to submit a job") |
| Get the status of the Ray job. | ||
|
|
||
| Args: | ||
| print_to_console: Whether to print formatted status to console (default: True) |
Collaborator
There was a problem hiding this comment.
nit
Suggested change
| print_to_console: Whether to print formatted status to console (default: True) | |
| print_to_console (bool) : Whether to print formatted status to console (default: True) |
|
|
||
| return rayjob_cr | ||
|
|
||
| def status(self, print_to_console: bool = True) -> Tuple[CodeflareRayJobStatus, bool]: |
Collaborator
There was a problem hiding this comment.
Question: Should we print to console true by default? I think that means in the output we get the table and an unformatted console print?
Owner
Author
There was a problem hiding this comment.
In this context its actually how we output the table. It's technically console output (the output section of a notebook in our case) that contains the tables. If we set this to false, it makes the API calls etc but suppresses the output. Means we could still check the return from the call without cluttering a log file if we wanted to.
chipspeak
force-pushed
the
RHOAIENG-26590
branch
8 times, most recently
from
33368c3 to
17faad7
Compare
Signed-off-by: Pat O'Connor <paoconno@redhat.com>
chipspeak
force-pushed
the
RHOAIENG-26590
branch
from
17faad7 to
d1be9e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.