add field checks for stats

Author: chloechia4

cuda_bindings/tests/test_cufile.py

@@ -2139,16 +2139,33 @@ def test_get_stats_l1():
         # Get L1 statistics (basic operation counts)
         cufile.get_stats_l1(stats_ptr)
 
-        # Verify that statistics data was written to the buffer
-        # Convert buffer to bytes and check that it's not all zeros
-        buffer_bytes = bytes(stats_buffer)
-        non_zero_bytes = sum(1 for b in buffer_bytes if b != 0)
-        assert non_zero_bytes > 0, (
-            f"Expected statistics data to be written to buffer, but got {non_zero_bytes} non-zero bytes"
-        )
-
-        # Verify statistics retrieval completed successfully
-        logging.info("cuFile L1 statistics retrieved successfully after file operations")
+        # Define ctypes structure matching CUfileStatsLevel1_t
+        class OpCounter(ctypes.Structure):
+            _fields_ = [("ok", ctypes.c_uint64), ("err", ctypes.c_uint64)]
+
+        class StatsL1(ctypes.Structure):
+            _fields_ = [
+                ("read_ops", OpCounter), ("write_ops", OpCounter),
+                ("hdl_register_ops", OpCounter), ("hdl_deregister_ops", OpCounter),
+                ("buf_register_ops", OpCounter), ("buf_deregister_ops", OpCounter),
+                ("read_bytes", ctypes.c_uint64), ("write_bytes", ctypes.c_uint64),
+                ("read_bw_bytes_per_sec", ctypes.c_uint64), ("write_bw_bytes_per_sec", ctypes.c_uint64),
+                ("read_lat_avg_us", ctypes.c_uint64), ("write_lat_avg_us", ctypes.c_uint64),
+                ("read_ops_per_sec", ctypes.c_uint64), ("write_ops_per_sec", ctypes.c_uint64),
+                ("read_lat_sum_us", ctypes.c_uint64), ("write_lat_sum_us", ctypes.c_uint64),
+            ]
+
+        # Cast buffer to structure and examine fields
+        stats = ctypes.cast(stats_ptr, ctypes.POINTER(StatsL1)).contents
+
+        # Verify actual field values
+        assert stats.read_ops.ok > 0, f"Expected read operations, got {stats.read_ops.ok}"
+        assert stats.write_ops.ok > 0, f"Expected write operations, got {stats.write_ops.ok}"
+        assert stats.read_bytes > 0, f"Expected read bytes, got {stats.read_bytes}"
+        assert stats.write_bytes > 0, f"Expected write bytes, got {stats.write_bytes}"
+
+        logging.info(f"Stats: reads={stats.read_ops.ok}, writes={stats.write_ops.ok}, "
+                    f"read_bytes={stats.read_bytes}, write_bytes={stats.write_bytes}")
 
         # Stop statistics collection
         cufile.stats_stop()
@@ -2165,7 +2182,6 @@ def test_get_stats_l1():
         cufile.driver_close()
         cuda.cuDevicePrimaryCtxRelease(device)
 
-
 @pytest.mark.skipif(
     cufileVersionLessThan(1150), reason="cuFile parameter APIs require cuFile library version 13.0 or later"
 )
@@ -2234,15 +2250,23 @@ def test_get_stats_l2():
         # Get L2 statistics (detailed performance metrics)
         cufile.get_stats_l2(stats_ptr)
 
-        # Verify that statistics data was written to the buffer
-        buffer_bytes = bytes(stats_buffer)
-        non_zero_bytes = sum(1 for b in buffer_bytes if b != 0)
-        assert non_zero_bytes > 0, (
-            f"Expected statistics data to be written to buffer, but got {non_zero_bytes} non-zero bytes"
-        )
+        # Define ctypes structure matching CUfileStatsLevel2_t
+        class StatsL2(ctypes.Structure):
+            _fields_ = [
+                ("basic", ctypes.c_byte * 512),  # L1 data (simplified)
+                ("read_size_kb_hist", ctypes.c_uint64 * 32),
+                ("write_size_kb_hist", ctypes.c_uint64 * 32),
+            ]
 
-        # Verify statistics retrieval completed successfully
-        logging.info("cuFile L2 statistics retrieved successfully after file operations")
+        # Cast buffer to structure and examine L2-specific fields
+        stats = ctypes.cast(stats_ptr, ctypes.POINTER(StatsL2)).contents
+
+        # Verify L2 histogram fields contain data
+        read_hist_total = sum(stats.read_size_kb_hist)
+        write_hist_total = sum(stats.write_size_kb_hist)
+        assert read_hist_total > 0 or write_hist_total > 0, "Expected L2 histogram data"
+
+        logging.info(f"L2 Stats: read_hist_total={read_hist_total}, write_hist_total={write_hist_total}")
 
         # Stop statistics collection
         cufile.stats_stop()
@@ -2331,15 +2355,42 @@ def test_get_stats_l3():
         # Get L3 statistics (comprehensive diagnostic data)
         cufile.get_stats_l3(stats_ptr)
 
-        # Verify that statistics data was written to the buffer
-        buffer_bytes = bytes(stats_buffer)
-        non_zero_bytes = sum(1 for b in buffer_bytes if b != 0)
-        assert non_zero_bytes > 0, (
-            f"Expected statistics data to be written to buffer, but got {non_zero_bytes} non-zero bytes"
-        )
-
-        # Verify statistics retrieval completed successfully
-        logging.info("cuFile L3 statistics retrieved successfully after file operations")
+        # Define ctypes structure matching CUfileStatsLevel3_t
+        class PerGpuStats(ctypes.Structure):
+            _fields_ = [
+                ("uuid", ctypes.c_char * 16),
+                ("read_bytes", ctypes.c_uint64),
+                ("read_bw_bytes_per_sec", ctypes.c_uint64),
+                ("read_utilization", ctypes.c_uint64),
+                ("read_duration_us", ctypes.c_uint64),
+                ("n_total_reads", ctypes.c_uint64),
+                ("n_p2p_reads", ctypes.c_uint64),
+                ("n_nvfs_reads", ctypes.c_uint64),
+                ("n_posix_reads", ctypes.c_uint64),
+            ]
+
+        class StatsL3(ctypes.Structure):
+            _fields_ = [
+                ("detailed", ctypes.c_byte * 2048),  # L2 data (simplified)
+                ("num_gpus", ctypes.c_uint32),
+                ("per_gpu_stats", PerGpuStats * 16),
+            ]
+
+        # Cast buffer to structure and examine L3-specific fields
+        stats = ctypes.cast(stats_ptr, ctypes.POINTER(StatsL3)).contents
+
+        # Verify L3-specific fields
+        assert stats.num_gpus >= 0, f"Expected valid GPU count, got {stats.num_gpus}"
+
+        # Check if we have at least one GPU with stats
+        gpu_with_data = False
+        for i in range(min(stats.num_gpus, 16)):
+            gpu_stats = stats.per_gpu_stats[i]
+            if gpu_stats.n_total_reads > 0 or gpu_stats.read_bytes > 0:
+                gpu_with_data = True
+                break
+
+        logging.info(f"L3 Stats: num_gpus={stats.num_gpus}, gpu_with_data={gpu_with_data}")
 
         # Stop statistics collection
         cufile.stats_stop()