Accept +00:00 and other zero-offset timezones as UTC#320
Conversation
Use our fork of the crate until chmp/serde_arrow#320 is merged. Signed-off-by: Leonid Ryzhyk <ryzhyk@gmail.com>
Use our fork of the crate until chmp/serde_arrow#320 is merged. Signed-off-by: Leonid Ryzhyk <ryzhyk@gmail.com>
Use our fork of the crate until chmp/serde_arrow#320 is merged. Signed-off-by: Leonid Ryzhyk <ryzhyk@gmail.com>
Use our fork of the crate until chmp/serde_arrow#320 is merged. Signed-off-by: Leonid Ryzhyk <ryzhyk@gmail.com>
Use our fork of the crate until chmp/serde_arrow#320 is merged. Signed-off-by: Leonid Ryzhyk <ryzhyk@gmail.com>
Use our fork of the crate until chmp/serde_arrow#320 is merged. Signed-off-by: Leonid Ryzhyk <ryzhyk@gmail.com>
Use our fork of the crate until chmp/serde_arrow#320 is merged. Signed-off-by: Leonid Ryzhyk <ryzhyk@gmail.com>
|
@ryzhyk Thanks a lot. looks good at first glance. Running tests just now. A question regarding release: I changed the public API, slightly, and removed support for outdated arrow versions in parallel. Before doing a proper major release, I would like to cut a pre-release first. Do you have any expectation for timelines?h |
|
@ryzhyk Could you fix some minor things before merging? Thanks a lot. (full disclosure these are findings by running an LLM over your change):
My findings:
My ask for clarification of 2 |
@chmp , we are currently using my fork of serde-arrow, but this means that we cannot release the fixed version of our crate that depends on it on crates.io until this PR makes it to the next release. So earlier would definitely be better, but I don't want to interfere with your release process. |
Arrow encodes every timezone-aware timestamp as a UTC instant; the timezone string is only a display hint. Previously, timestamp deserializer only recognized the "UTC" string as UTC timezone specifier. This commit adds support for other zero-offset designators (+00:00, -00:00, +0000, -0000, Z) alongside "UTC" through a shared is_utc_timezone helper used by both the deserialization and serialization paths.
- Update stale docs. - Test the serialization path. - Update changelog. Signed-off-by: Leonid Ryzhyk <ryzhyk@gmail.com>
9555b34 to
4e6587e
Compare
|
@chmp , I rebased and addressed your comments. Thanks for the review! |
|
Thanks a lot. I took the liberty of performing some minor changes myself:
|
|
Re. Release: I will release another pre-release (0.15.0-rc.2), before a stable release I would like to test first for a bit in my own consumers whether anything breaks. The plan would be to cut a proper release next week. |
|
Released your changes as |
Arrow encodes every timezone-aware timestamp as a UTC instant; the timezone string is only a display hint. Previously, timestamp deserializer only recognized the "UTC" string as UTC timezone specifier. This commit adds support for other zero-offset designators (+00:00, -00:00, +0000, -0000, Z) alongside "UTC" through a shared is_utc_timezone helper used by both the deserialization and serialization paths.