-
Notifications
You must be signed in to change notification settings - Fork 949
new - Escape illegal XML characters that would be passed into the nuspec #1534
Copy link
Copy link
Open
Labels
3 - ReviewCode has been added, and is available for review as a pull request.Code has been added, and is available for review as a pull request.EnhancementIssues that introduce new functionality to the project, or enhances/updates existing functionality.Issues that introduce new functionality to the project, or enhances/updates existing functionality.Priority - LowRepresents issues that are of lower priority, can be taken care of whenever.Represents issues that are of lower priority, can be taken care of whenever.Up For GrabsIssues that are available by the community to work on.Issues that are available by the community to work on.
Milestone
Metadata
Metadata
Assignees
Labels
3 - ReviewCode has been added, and is available for review as a pull request.Code has been added, and is available for review as a pull request.EnhancementIssues that introduce new functionality to the project, or enhances/updates existing functionality.Issues that introduce new functionality to the project, or enhances/updates existing functionality.Priority - LowRepresents issues that are of lower priority, can be taken care of whenever.Represents issues that are of lower priority, can be taken care of whenever.Up For GrabsIssues that are available by the community to work on.Issues that are available by the community to work on.
Type
Fields
Give feedbackNo fields configured for issues without a type.
What You Are Seeing?
choco newpermits illegal XML characters to be passed into the .nuspec file which can prevent choco pack from succeeding.What is Expected?
It should either reject the input or correct it automatically--the later being nicer option when setting the title to the software's display name automatically/with helper tools.
In my specific situation, my package names are CLI friendly and follow a predictable scheme while the title is set to match the package's name as it appears in Programs and Features. Some of the names contain characters such as &. The behavior of
choco newplaces the burden on the toolmaker for sanitizing input.How Did You Get This To Happen? (Steps to Reproduce)
Pass in an illegal XML character into the title element with
choco new.choco new A^&Busing CMDIt lets you despite how that will not be able to be packaged.
Or directly edit the .nuspec as such
Execute
choco pack...