Fix #14564 FP AssignmentIntegerToAddress (MAKEINTRESOURCE() in windows.cfg) (cppcheck-opensource#8295)

chrchr-github · web-flow · commit 8aba11e752b3 · 2026-03-31T19:37:25.000+02:00
diff --git a/cfg/windows.cfg b/cfg/windows.cfg
@@ -13345,9 +13345,9 @@ HFONT CreateFont(
   <define name="MiniDumpWithAvxXStateContext" value="0x0200000"/>
   <define name="MiniDumpWithIptTrace" value="0x0400000"/>
   <define name="MiniDumpValidTypeFlags" value="0x0800000"/>
-  <define name="MAKEINTRESOURCEA(i)" value="i"/>
-  <define name="MAKEINTRESOURCEW(i)" value="i"/>
-  <define name="MAKEINTRESOURCE(i)" value="i"/>
+  <define name="MAKEINTRESOURCEA(i)" value="((LPSTR)((ULONG_PTR)((WORD)(i))))"/>
+  <define name="MAKEINTRESOURCEW(i)" value="((LPWSTR)((ULONG_PTR)((WORD)(i))))"/>
+  <define name="MAKEINTRESOURCE(i)" value="((LPTSTR)((ULONG_PTR)((WORD)(i))))"/>
   <define name="FILE_ATTRIBUTE_ARCHIVE" value="0x20"/>
   <define name="FILE_ATTRIBUTE_COMPRESSED" value="0x800"/>
   <define name="FILE_ATTRIBUTE_DEVICE" value="0x40"/>
diff --git a/test/cfg/windows.cpp b/test/cfg/windows.cpp
@@ -93,6 +93,10 @@ std::string constVariable_GetModuleFileName(void) {
     return std::string{path};
 }
 
+const TCHAR* constVariable_MAKEINTRESOURCE() { // #14564
+    return MAKEINTRESOURCE(5 - 1);
+}
+
 int stringCompare_mbscmp(const unsigned char *string1, const unsigned char *string2)
 {
     // cppcheck-suppress stringCompare

Original file line number	Diff line number	Diff line change
`@@ -93,6 +93,10 @@ std::string constVariable_GetModuleFileName(void) {`
`93`	`93`	`return std::string{path};`
`94`	`94`	`}`
`95`	`95`
	`96`	`+const TCHAR* constVariable_MAKEINTRESOURCE() { // #14564`
	`97`	`+ return MAKEINTRESOURCE(5 - 1);`
	`98`	`+}`
	`99`	`+`
`96`	`100`	`int stringCompare_mbscmp(const unsigned char string1, const unsigned char string2)`
`97`	`101`	`{`
`98`	`102`	`// cppcheck-suppress stringCompare`