Skip to content

Commit 2ee693b

Browse files
feat(ingest/mssql): skip inaccessible databases when configured database=null (datahub-project#16683)
Co-authored-by: kyungsoo-datahub <kyungsoo.lee@datahub.com>
1 parent 6f144bc commit 2ee693b

1 file changed

Lines changed: 13 additions & 2 deletions

File tree

  • metadata-ingestion/src/datahub/ingestion/source/sql/mssql

metadata-ingestion/src/datahub/ingestion/source/sql/mssql/source.py

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1320,8 +1320,19 @@ def get_inspectors(self) -> Iterable[Inspector]:
13201320
url = self.config.get_sql_alchemy_url(
13211321
current_db=db["name"], is_odbc=self._is_odbc
13221322
)
1323-
engine = create_engine(url, **self.config.options)
1324-
inspector = inspect(engine)
1323+
try:
1324+
engine = create_engine(url, **self.config.options)
1325+
inspector = inspect(engine)
1326+
except OperationalError as e:
1327+
if re.search(r"(?i)login failed", str(e)):
1328+
logger.warning(
1329+
f"Error logging in to database {db['name']}: {e}"
1330+
)
1331+
self.report.report_warning(
1332+
"Error logging in to database", db["name"], exc=e
1333+
)
1334+
continue
1335+
raise
13251336
self.current_database = db["name"]
13261337
yield inspector
13271338

0 commit comments

Comments
 (0)