Fix asyncio event-loop leak; expand CI to the full non-browser suite (#184)

* test(claude_session): remove orphaned fixtures test left by #174

#174 (aa815ee) intentionally deleted mcp/claude-session/fixtures/ (the
MalformedWriteToolInput model + its fixture + manifest.json) but left
tests/claude_session/test_fixtures.py asserting that now-missing directory --
silently red on main since. Remove the dead test, its dir-local conftest,
and the now-empty test package.

* fix(tests): upgrade pytest-asyncio 1.3.0 -> 1.4.0 (event-loop leak)

1.3.0's _temporary_event_loop_policy captured the current loop via
asyncio.get_event_loop() to restore per async test; on Python 3.13 that
fabricates an unclosed _UnixSelectorEventLoop + AF_UNIX socketpair, which
filterwarnings=["error"] escalated into a non-deterministic
PytestUnraisableExceptionWarning landing on a random victim test. 1.4.0
drops the loop capture/restore (upstream pytest-dev/pytest-asyncio#1164).

Verified: the previously non-deterministic cc_lib+crb+hooks combo now
passes 429/429 across repeated runs.

* ci: run the full suite (minus browser-only selenium) on every PR

The pytest-asyncio 1.4.0 loop-leak fix + orphan-test cleanup make the
non-browser suite deterministic, so CI now guards all 830 of those tests
instead of just tests/linters/. tests/selenium_browser needs a real browser
the ubuntu runner lacks; it gets a dedicated browser job in a follow-up.

* ci: install zsh for claude-remote-bash executor tests

The crb executor runs commands in /bin/zsh (its configured shell); ubuntu
runners don't ship zsh, so 12 test_executor.py tests failed with
FileNotFoundError. Same shape as libsnappy: a real crb runtime dependency
the runner must provide.

Author: chrisguillory

.github/workflows/ci.yml

@@ -22,16 +22,18 @@ jobs:
         with:
           python-version: '3.13'
           enable-cache: true
-      - name: System libraries for native deps
-        # python-snappy (selenium-browser -> dfindexeddb) builds from source on Linux; needs libsnappy headers.
-        run: sudo apt-get update && sudo apt-get install -y libsnappy-dev
+      - name: System dependencies
+        # libsnappy-dev: python-snappy (selenium-browser -> dfindexeddb) builds from source on Linux.
+        # zsh: claude-remote-bash runs commands in /bin/zsh, exercised by the executor tests.
+        run: sudo apt-get update && sudo apt-get install -y libsnappy-dev zsh
       - name: Sync workspace
         run: uv sync --locked --all-packages --all-groups
       - name: Lint, format, type-check, custom linters (pre-commit)
         run: uv run pre-commit run --all-files --show-diff-on-failure
       - name: Tests
-        # tests/linters/ only — the rest of tests/ has pre-existing cross-test pollution to fix first.
-        run: uv run pytest tests/linters/
+        # Full suite except selenium_browser, which needs a real browser the runner lacks
+        # (covered by a dedicated browser job in a follow-up). Deterministic + green here.
+        run: uv run pytest tests/ --ignore=tests/selenium_browser
 
   merge-gatekeeper:
     name: merge-gatekeeper # required-status-check context — keep in sync with the branch ruleset

pyproject.toml

@@ -222,7 +222,13 @@ dev = [
     "pydantic>=2.12.5", # Required for pydantic.mypy plugin
     "pymupdf-stubs>=1.26.1.post1",
     "pytest>=9.0.2",
-    "pytest-asyncio>=1.3.0",
+    # >=1.4.0: 1.3.0's _temporary_event_loop_policy captured the "current" loop via
+    # asyncio.get_event_loop() to restore after each async test. On Python 3.13 that
+    # call fabricates a _UnixSelectorEventLoop (+ AF_UNIX socketpair self-pipe) when
+    # no loop is set, then never closes it — a ResourceWarning that filterwarnings=
+    # ["error"] escalated onto a random victim test. 1.4.0 drops the loop capture/
+    # restore, saving/restoring only the event-loop policy (upstream #1164).
+    "pytest-asyncio>=1.4.0",
     "pytest-mypy-plugins>=3.3.0",
     "ruff>=0.14.10",
     "typer>=0.9.0",