Skip to content

Commit 135cd9e

Browse files
authored
Merge pull request #39 from chrisjwalk/chore/remove-moment-lodash-31
chore: remove moment.js and replace lodash with native JS
2 parents 8991241 + 587c422 commit 135cd9e

3 files changed

Lines changed: 4 additions & 22 deletions

File tree

libs/weather-forecast/src/lib/state/weather-forecast.store.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ import {
1717
} from '@ngrx/signals';
1818
import { setAllEntities, withEntities } from '@ngrx/signals/entities';
1919
import { rxMethod } from '@ngrx/signals/rxjs-interop';
20-
import { isEqual, isNil } from 'lodash';
2120
import { pipe, switchMap, tap } from 'rxjs';
2221

2322
import {
@@ -97,7 +96,8 @@ export function withWeatherForecastFeature() {
9796

9897
withMethods(({ layoutStore, weatherForecasts, ...store }) => ({
9998
getForecasts(request: { count: number; plus: boolean }) {
100-
const reload = isEqual(store.request(), request);
99+
const reload =
100+
JSON.stringify(store.request()) === JSON.stringify(request);
101101

102102
layoutStore.setCount(request.count);
103103
patchState(store, request);
@@ -142,9 +142,9 @@ export function weatherForecastFilter(
142142
filteredForecasts: computed(() =>
143143
weatherForecasts()?.filter(
144144
(forecast) =>
145-
(isNil(store.filter()?.minTemperatureC) ||
145+
(store.filter()?.minTemperatureC == null ||
146146
forecast.temperatureC >= store.filter()?.minTemperatureC) &&
147-
(isNil(store.filter()?.maxTemperatureC) ||
147+
(store.filter()?.maxTemperatureC == null ||
148148
forecast.temperatureC <= store.filter()?.maxTemperatureC),
149149
),
150150
),

package.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,9 +73,7 @@
7373
"@tailwindcss/postcss": "4.2.1",
7474
"chalk": "5.6.2",
7575
"inquirer": "13.3.0",
76-
"lodash": "4.17.23",
7776
"marked": "17.0.4",
78-
"moment": "2.30.1",
7977
"ngx-markdown": "21.1.0",
8078
"rxjs": "7.8.2",
8179
"tslib": "2.8.1"

pnpm-lock.yaml

Lines changed: 0 additions & 16 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)