fix: update e2e tests to match current UI (closes #104) (#105)

- Use exact label match for Password field to avoid matching show/hide toggle
- Update login button selector from 'Login' to 'Sign in'
- Update toolbar nav from button role to link role with current labels

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: chrisjwalk-bot

apps/web-app-e2e/src/login.e2e.spec.ts

@@ -11,13 +11,13 @@ test.describe('Login page', () => {
     await page.goto('/login');
 
     await expect(page.getByLabel('Email')).toBeVisible();
-    await expect(page.getByLabel('Password')).toBeVisible();
+    await expect(page.getByLabel('Password', { exact: true })).toBeVisible();
   });
 
-  test('should display a Login button', async ({ page }) => {
+  test('should display a Sign in button', async ({ page }) => {
     await page.goto('/login');
 
-    await expect(page.getByRole('button', { name: /login/i })).toBeVisible();
+    await expect(page.getByRole('button', { name: /sign in/i })).toBeVisible();
   });
 
   test('login button should be disabled when form is invalid', async ({
@@ -28,7 +28,7 @@ test.describe('Login page', () => {
     // Clear the pre-filled email so the form becomes invalid
     await page.getByLabel('Email').fill('');
 
-    await expect(page.getByRole('button', { name: /login/i })).toBeDisabled();
+    await expect(page.getByRole('button', { name: /sign in/i })).toBeDisabled();
   });
 
   test('login button should be enabled when form is valid', async ({
@@ -37,8 +37,8 @@ test.describe('Login page', () => {
     await page.goto('/login');
 
     await page.getByLabel('Email').fill('user@example.com');
-    await page.getByLabel('Password').fill('password123');
+    await page.getByLabel('Password', { exact: true }).fill('password123');
 
-    await expect(page.getByRole('button', { name: /login/i })).toBeEnabled();
+    await expect(page.getByRole('button', { name: /sign in/i })).toBeEnabled();
   });
 });

apps/web-app-e2e/src/navigation.e2e.spec.ts

@@ -4,23 +4,23 @@ test.describe('Navigation', () => {
   test.describe('toolbar (desktop)', () => {
     test.use({ viewport: { width: 1280, height: 720 } });
 
-    test('should navigate to weather forecast page via toolbar button', async ({
+    test('should navigate to weather forecast page via toolbar link', async ({
       page,
     }) => {
       await page.goto('/');
 
-      await page.getByRole('button', { name: 'Get Data Feature' }).click();
+      await page.getByRole('link', { name: 'Weather Forecasts' }).click();
 
       await expect(page).toHaveURL(/\/weather-forecast/);
       await expect(page.getByTestId('lib-weather-forecast')).toBeVisible();
     });
 
-    test('should navigate to counter page via toolbar button', async ({
+    test('should navigate to counter page via toolbar link', async ({
       page,
     }) => {
       await page.goto('/');
 
-      await page.getByRole('button', { name: 'Lazy Loaded Feature' }).click();
+      await page.getByRole('link', { name: 'Counter' }).click();
 
       await expect(page).toHaveURL(/\/feature/);
       await expect(page.getByTestId('lib-counter-container')).toBeVisible();