Commit db967e9
fix: add explicit GITHUB_TOKEN permissions to workflows (#74)
* fix: add explicit GITHUB_TOKEN permissions to workflows (closes #73)
Lock down GITHUB_TOKEN to minimum required permissions per job,
following principle of least privilege (CodeQL alerts #1, #2, #3).
ci.yml: contents: read, pull-requests: write
preview.yml: deploy_preview: contents: read + pull-requests: write
close_preview: pull-requests: write only (no checkout)
deploy.yml already had explicit permissions and is unchanged.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* fix: skip coverage comment steps when no coverage files are generated
When a PR only changes non-code files (e.g. workflow YAML), nx affected
runs no tests so no coverage XML is produced and code-coverage-results.md
is never created. The sticky-pull-request-comment step then fails with
'Either message or path input is required'.
- Add continue-on-error to CodeCoverageSummary (graceful no-op)
- Add a Check step that sets coverage.outputs.exists
- Gate annotate, summary, and comment steps on that output
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>1 parent 0b81370 commit db967e9
2 files changed
Lines changed: 19 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
12 | 16 | | |
13 | 17 | | |
14 | 18 | | |
| |||
83 | 87 | | |
84 | 88 | | |
85 | 89 | | |
| 90 | + | |
86 | 91 | | |
87 | 92 | | |
88 | 93 | | |
| |||
92 | 97 | | |
93 | 98 | | |
94 | 99 | | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
95 | 106 | | |
96 | | - | |
| 107 | + | |
97 | 108 | | |
98 | 109 | | |
99 | 110 | | |
| |||
102 | 113 | | |
103 | 114 | | |
104 | 115 | | |
105 | | - | |
| 116 | + | |
106 | 117 | | |
107 | 118 | | |
108 | 119 | | |
109 | | - | |
| 120 | + | |
110 | 121 | | |
111 | 122 | | |
112 | 123 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
17 | 20 | | |
18 | 21 | | |
19 | 22 | | |
| |||
49 | 52 | | |
50 | 53 | | |
51 | 54 | | |
| 55 | + | |
| 56 | + | |
52 | 57 | | |
53 | 58 | | |
54 | 59 | | |
| |||
0 commit comments