test: restructure tests

Author: afuetterer

tests/conftest.py

@@ -0,0 +1,9 @@
+from pathlib import Path
+
+import pytest
+
+
+@pytest.fixture
+def test_file_path():
+    return Path(__file__).parent / "files" / "rwservlet.pdf"
+

tests/test_detector.py

@@ -1,17 +1,13 @@
-from pathlib import Path
-
 from tika import detector
 
-TEST_FILE_PATH = Path(__file__).parent / "files" / "rwservlet.pdf"
-
 
-def test_local_binary():
-    with open(TEST_FILE_PATH, "rb") as file_obj:
+def test_local_binary(test_file_path):
+    with open(test_file_path, "rb") as file_obj:
         assert detector.from_file(file_obj) == "application/pdf"
 
 
-def test_local_path():
-    assert detector.from_file(str(TEST_FILE_PATH)) == "application/pdf"
+def test_local_path(test_file_path):
+    assert detector.from_file(str(test_file_path)) == "application/pdf"
 
 
 def test_local_buffer():

tests/test_language.py

@@ -1,17 +1,13 @@
-from pathlib import Path
-
 from tika import language
 
-TEST_FILE_PATH = Path(__file__).parent / "files" / "rwservlet.pdf"
-
 
-def test_local_binary():
-    with open(TEST_FILE_PATH, "rb") as file_obj:
+def test_local_binary(test_file_path):
+    with open(test_file_path, "rb") as file_obj:
         assert language.from_file(file_obj) == "en"
 
 
-def test_local_path():
-    assert language.from_file(str(TEST_FILE_PATH)) == "en"
+def test_local_path(test_file_path):
+    assert language.from_file(str(test_file_path)) == "en"
 
 
 def test_local_buffer():

tests/test_parser.py

@@ -0,0 +1,43 @@
+from http import HTTPStatus
+
+from tika import parser
+
+
+def test_remote_pdf():
+    """parse remote PDF"""
+    assert parser.from_file(
+        "https://upload.wikimedia.org/wikipedia/commons/4/42/Article_feedback_flow_B_-_Thank_editors.pdf")
+
+
+def test_remote_html():
+    """parse remote HTML"""
+    assert parser.from_file("http://nossl.sh")
+
+
+def test_remote_mp3():
+    """parse remote mp3"""
+    assert parser.from_file(
+        "https://archive.org/download/Ainst-Spaceshipdemo.mp3/Ainst-Spaceshipdemo.mp3")
+
+
+def test_remote_jpg():
+    """parse remote jpg"""
+    assert parser.from_file(
+        "https://upload.wikimedia.org/wikipedia/commons/b/b7/X_logo.jpg")
+
+
+def test_local_binary(test_file_path):
+    """parse file binary"""
+    with open(test_file_path, "rb") as file_obj:
+        assert parser.from_file(file_obj)
+
+
+def test_local_buffer():
+    response = parser.from_buffer("Good evening, Dave")
+    assert response["status"] == HTTPStatus.OK
+
+
+def test_local_path(test_file_path):
+    """parse file path"""
+    assert parser.from_file(str(test_file_path))
+

tests/test_pdf.py

@@ -1,10 +1,6 @@
-from pathlib import Path
-
 from tika import pdf
 
-TEST_FILE_PATH = Path(__file__).parent / "files" / "rwservlet.pdf"
-
 
-def test_local_path():
-    text_pages = pdf.text_from_pdf_pages(str(TEST_FILE_PATH))
+def test_local_path(test_file_path):
+    text_pages = pdf.text_from_pdf_pages(str(test_file_path))
     assert isinstance(text_pages, list)

tests/test_tika.py

@@ -14,56 +14,12 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-from http import HTTPStatus
-from pathlib import Path
-
-import tika.parser
 import tika.tika
-
-TEST_FILE_PATH = Path(__file__).parent / "files" / "rwservlet.pdf"
-
-
-def test_remote_pdf():
-    """parse remote PDF"""
-    assert tika.parser.from_file(
-        "https://upload.wikimedia.org/wikipedia/commons/4/42/Article_feedback_flow_B_-_Thank_editors.pdf")
-
-
-def test_remote_html():
-    """parse remote HTML"""
-    assert tika.parser.from_file("http://nossl.sh")
-
-
-def test_remote_mp3():
-    """parse remote mp3"""
-    assert tika.parser.from_file(
-        "https://archive.org/download/Ainst-Spaceshipdemo.mp3/Ainst-Spaceshipdemo.mp3")
-
-
-def test_remote_jpg():
-    """parse remote jpg"""
-    assert tika.parser.from_file(
-        "https://upload.wikimedia.org/wikipedia/commons/b/b7/X_logo.jpg")
-
-
-def test_local_binary():
-    """parse file binary"""
-    with open(TEST_FILE_PATH, "rb") as file_obj:
-        assert tika.parser.from_file(file_obj)
-
-
-def test_local_buffer():
-    response = tika.parser.from_buffer("Good evening, Dave")
-    assert response["status"] == HTTPStatus.OK
-
-
-def test_local_path():
-    """parse file path"""
-    assert tika.parser.from_file(str(TEST_FILE_PATH))
+from tika import parser
 
 
-def test_kill_server():
+def test_kill_server(test_file_path):
     """parse some file then kills server"""
-    with open(TEST_FILE_PATH, "rb") as file_obj:
+    with open(test_file_path, "rb") as file_obj:
         tika.parser.from_file(file_obj)
     assert tika.tika.killServer() is None