Removed readme Guides link that returned 404#76
Open
powelli13 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Guides link in the readme pointed to
https://phoenixframework.org/docs/overviewwhich returned a 404. However clicking the "Guides" link from thehttps://phoenixframework.org/page navigates to the same page as the Docs link in the readme. In order to correct this I removed the Guides link and updated the Docs label to indicate that both Docs and Guides are found on the same Hex PM Overview page.Also I found this 404 issue when browsing this repo after reading Programming Phoenix 1.4. I really, really enjoyed the book! Thanks for writing it and providing so many awesome examples.