fix isUrl pipeline char#342
Open
ghost wants to merge 1 commit into
Open
Conversation
Collaborator
|
It makes sense to change the validator to Diego Perini variant: |
Collaborator
|
I'm in favor of moving to the @dperini regex. We can hardcode, but I'd also be okay with pulling in https://github.com/kevva/url-regex. Mainly since it seems that there are occasional updates to the regex itself. So it's nice to have a repo that keeps up to date with the original gist and runs unit tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The regular expression used to validate the urls, doesn't match a regular uri like this:
https://www.google.it/search?q=to+be+||+not+to+be
The problem is that the actual regex, doesn't match the "pipeline char" of the parameter's values.