Skip to content

Update to use "prop-types" dependency#450

Open
ottis wants to merge 2 commits into
christianalfoni:masterfrom
ottis:feature/propTypeDependency
Open

Update to use "prop-types" dependency#450
ottis wants to merge 2 commits into
christianalfoni:masterfrom
ottis:feature/propTypeDependency

Conversation

@ottis
Copy link
Copy Markdown

@ottis ottis commented May 21, 2017

Description

In the console there was an annoying warning from React:

"Warning: Accessing PropTypes via the main React package is deprecated. Use the prop-types package from npm instead."

This PR adds the prop-types dependency to the project, and updates the references.
https://github.com/facebook/prop-types

Changes

Files changed

  • Mixin.js (updating references)
  • main.js (updating references)

Tests/Examples

Tests are passing, examples run fine

…d of the one from the react package. This is because accessing PropTypes from the main React package is deprecated
@ottis ottis changed the title Update to use "prop-type" dependency Update to use "prop-types" dependency May 21, 2017
@mijamo
Copy link
Copy Markdown

mijamo commented May 22, 2017

You might want to take a look at #439 that also fixed those issues but might lead to a more elaborate rewriting apparently.

@ottis
Copy link
Copy Markdown
Author

ottis commented May 22, 2017

Ah I see (I didn't try and tackle the createClass issue as it looked like a rewrite as you mentioned), maybe i'll jump onto that branch and see if there's anything I can help with 😄 cheers!

@drewlustro
Copy link
Copy Markdown

🏆

I really wish this would be merged in and accepted into master before the massive rewrite at #439 gets vetted. There is very little reason tolerate these warnings given the fix is so simple.

@ottis
Copy link
Copy Markdown
Author

ottis commented Aug 21, 2017

@drewlustro I'm in agreement, would be good to get rid of these annoying warnings for now, not sure when that massive rewrite is going to be merged ☹️

@aesopwolf
Copy link
Copy Markdown
Collaborator

@ottis and @drewlustro are you guys on the latest version? v0.19.5?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants