test: check if database parameter are initialized before emitting metrics

Author: christiangalsterer

src/pgClientPrometheusExporter.ts

@@ -56,20 +56,24 @@ export class PgClientPrometheusExporter {
   }
 
   onClientError(_error: Error): void {
-    this.clientErrors.inc(
-      mergeLabelsWithStandardLabels(
-        { host: this.client.host + ':' + this.client.port.toString(), database: this.client.database! },
-        this.options.defaultLabels
+    if (this.client.database != null) {
+      this.clientErrors.inc(
+        mergeLabelsWithStandardLabels(
+          { host: this.client.host + ':' + this.client.port.toString(), database: this.client.database },
+          this.options.defaultLabels
+        )
       )
-    )
+    }
   }
 
   onClientEnd(): void {
-    this.clientDisconnects.inc(
-      mergeLabelsWithStandardLabels(
-        { host: this.client.host + ':' + this.client.port.toString(), database: this.client.database! },
-        this.options.defaultLabels
+    if (this.client.database != null) {
+      this.clientDisconnects.inc(
+        mergeLabelsWithStandardLabels(
+          { host: this.client.host + ':' + this.client.port.toString(), database: this.client.database },
+          this.options.defaultLabels
+        )
       )
-    )
+    }
   }
 }

src/pgPoolPrometheusExporter.ts

@@ -73,13 +73,13 @@ export class PgPoolPrometheusExporter {
             labelNames: mergeLabelNamesWithStandardLabels(['host', 'database'], this.options.defaultLabels),
             registers: [this.register],
             collect: () => {
-              if (this.poolHost != null && this.poolDatabase != null) {
+              if (this.poolHost != null && this.poolDatabase != null && this.poolMaxSize != null) {
                 this.poolSizeMax.set(
                   mergeLabelsWithStandardLabels(
                     { host: this.poolHost + ':' + this.poolPort.toString(), database: this.poolDatabase },
                     this.options.defaultLabels
                   ),
-                  this.poolMaxSize!
+                  this.poolMaxSize
                 )
               }
             }

src/utils.ts

@@ -50,7 +50,6 @@ export function getHost(pool: Pool): string | undefined {
  * Tries to determine the port configuration from the pool via direct property access as the configuration is not exported
  * @param pool the pool from which to get the property
  * @returns the configured port or 5432 if not set
- * @see https://node-postgres.com/api/pool#pool-connection-parameters
  */
 export function getPort(pool: Pool): number {
   // eslint-disable-next-line @typescript-eslint/no-magic-numbers