Fix rc2qt hex decoding, remove Python-style b'' from C++ output#43
Open
nyanpasu64 wants to merge 2 commits into
Open
Fix rc2qt hex decoding, remove Python-style b'' from C++ output#43nyanpasu64 wants to merge 2 commits into
nyanpasu64 wants to merge 2 commits into
Conversation
Contributor
Author
|
I have a script to regenerate cqtmfc_famitracker.cpp: #!/bin/sh
cd $(git rev-parse --show-toplevel)
python tools/rc2qt/rc2qt.py \
libs/famitracker/FamiTracker.rc \
> libs/famitracker/cqtmfc_famitracker.cppShould I add this to master? I'm currently using my own version (adapted for j0cc) on my unfinished j0cc branch. |
Owner
|
Yes, please merge that script. |
Contributor
Author
|
pushed again? the presence of the broken script in master makes me uncomfortable. |
Owner
|
What broken script? |
Contributor
Author
|
the .py in master is broken and produces incorrect output. |
Owner
|
Fixed.
…On Thu, Jun 27, 2019 at 11:22 AM jimbo1qaz ***@***.***> wrote:
the .py in master is broken and produces incorrect output.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#43?email_source=notifications&email_token=AAMQR4A34XJ2IA3UHZ5S5LLP4TSNJA5CNFSM4H2V7A72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYXUX7Y#issuecomment-506416127>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAMQR4AACVYCL22BUXFIXFTP4TSNJANCNFSM4H2V7A7Q>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The resulting cqtmfc_famitracker.cpp is identical to the outdated version from master.