[1.15] Fix sh not returning results#689
Conversation
|
Thanks for reporting this. Are you able to replicate this not working, with a test? |
|
Are there any downsides to making this change? |
no |
|
#614 would've portably fixed it fwiw, scanning manually instead of using the shell |
|
This issue has been automatically marked as stale because there has been no recent activity. It will be closed after 30 days if no further activity occurs. Thank you for your contributions. |
|
Hi! How was this not implemented? It's still an issue in Alpine Linux, which uses Busybox Ash shell. Should we propose a new PR? @GrahamCampbell |
There was a problem hiding this comment.
Pull request overview
This PR fixes Chrome binary auto-discovery on Linux distributions where /bin/sh is dash, by avoiding command -v invocation with multiple arguments (unsupported by dash) and instead checking candidates one-by-one.
Changes:
- Update Linux Chrome binary detection to use
command -v <candidate> || command -v <candidate> ...chaining. - Preserve existing behavior by still returning the first discovered binary path (or defaulting to
chrome).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Some Linux distributions use dash as the default sh, but in "dash", "command -v" only supports a single argument.