Use random_bytes function to generate mask (#22)

divinity76 · web-flow · commit 18aab0578d6c · 2025-05-01T12:16:55.000+01:00
diff --git a/src/Frame/HybiFrame.php b/src/Frame/HybiFrame.php
@@ -133,13 +133,7 @@ public function encode(string $payload, int $type = Protocol::TYPE_TEXT, bool $m
      */
     protected function generateMask()
     {
-        if (\extension_loaded('openssl')) {
-            return \openssl_random_pseudo_bytes(4);
-        } else {
-            // SHA1 is 128 bit (= 16 bytes)
-            // So we pack it into 32 bits
-            return \pack('N', \sha1(\spl_object_hash($this).\mt_rand(0, \PHP_INT_MAX).\uniqid('', true), true));
-        }
+        return \random_bytes(4);
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -133,13 +133,7 @@ public function encode(string $payload, int $type = Protocol::TYPE_TEXT, bool $m`
`133`	`133`	`*/`
`134`	`134`	`protected function generateMask()`
`135`	`135`	`{`
`136`		`- if (\extension_loaded('openssl')) {`
`137`		`- return \openssl_random_pseudo_bytes(4);`
`138`		`- } else {`
`139`		`- // SHA1 is 128 bit (= 16 bytes)`
`140`		`- // So we pack it into 32 bits`
`141`		`- return \pack('N', \sha1(\spl_object_hash($this).\mt_rand(0, \PHP_INT_MAX).\uniqid('', true), true));`
`142`		`- }`
	`136`	`+ return \random_bytes(4);`
`143`	`137`	`}`
`144`	`138`
`145`	`139`	`/**`