Fix waitForData crash when the socket is disconnected (#33)

Author: GrahamCampbell

src/Client.php

@@ -302,6 +302,10 @@ protected function configure(array $options): void
      */
     public function waitForData(float $maxSeconds): ?bool
     {
+        if (!$this->isConnected()) {
+            return null;
+        }
+
         return $this->socket->waitForData($maxSeconds);
     }
 }

src/Socket/AbstractSocket.php

@@ -233,6 +233,10 @@ public function send(string $data): ?int
      */
     public function waitForData(float $maxSeconds): ?bool
     {
+        if (null === $this->socket) {
+            return null;
+        }
+
         $read = [$this->socket];
         $write = null;
         $except = null;

tests/ClientTest.php

@@ -89,6 +89,7 @@ public function testSend(): void
             $instance->addRequestHeader('X-Test', 'Custom Request Header');
 
             self::assertNull($instance->receive(), 'Receive before connect');
+            self::assertNull($instance->waitForData(0), 'Wait for data before connect');
 
             $success = $instance->connect();
             self::assertTrue($success, 'Client can connect to test server');
@@ -123,6 +124,7 @@ public function testSend(): void
             $instance->disconnect();
 
             self::assertFalse($instance->isConnected());
+            self::assertNull($instance->waitForData(0), 'Wait for data after disconnect');
         } finally {
             $helper->tearDown();
         }

tests/Socket/ClientSocketTest.php

@@ -110,6 +110,13 @@ public function testSendTooEarly(): void
         $instance->send('foo');
     }
 
+    public function testWaitForDataTooEarly(): void
+    {
+        $instance = self::getInstance('ws://localhost:8000');
+
+        self::assertNull($instance->waitForData(0));
+    }
+
     /**
      * Test the connect, send, receive method.
      */