Fixes & dependencies updates#30
Closed
konstantinzolotarev wants to merge 4 commits into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request focuses on code quality improvements and dependency updates. It enhances error handling throughout the application, fixes a spelling mistake in method names, optimizes return types, and updates numerous dependencies to their latest versions.
Changes:
- Improved error handling with better error propagation in async tasks and more descriptive error messages
- Fixed typo: renamed
is_op_poke_challangebletois_op_poke_challengeableacross the codebase - Optimized
Event::title()return type fromStringto&'static strto avoid allocations - Extracted magic numbers to named constants for better maintainability
- Updated dependencies including alloy (1.0 → 1.6), tokio, metrics, and many others
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/main.rs | Enhanced error handling with constants extraction, proper error propagation in spawned tasks, and better handling of wallet/port configuration errors |
| crates/scribe/src/provider.rs | Improved error message clarity with expect() instead of unwrap() |
| crates/scribe/src/events_poller.rs | Changed panic to error return for missing channel, added error handling continuation |
| crates/scribe/src/event_processor.rs | Fixed typo in method name, changed return type to Result for proper error propagation, improved error handling |
| crates/scribe/src/event.rs | Optimized title() method to return &'static str instead of String |
| crates/scribe/src/error.rs | Reorganized error variants, added MissingBlockNumber and ChannelNotFound errors, improved error messages |
| crates/scribe/src/contract.rs | Added wrap_contract_error helper method, fixed typo in method name, improved error handling |
| Cargo.toml | Updated workspace dependencies to latest versions, removed unused testing_logger |
| Cargo.lock | Lockfile updates reflecting dependency version changes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.