Skip to content

Fixes & dependencies updates#30

Closed
konstantinzolotarev wants to merge 4 commits into
mainfrom
fixes
Closed

Fixes & dependencies updates#30
konstantinzolotarev wants to merge 4 commits into
mainfrom
fixes

Conversation

@konstantinzolotarev

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request focuses on code quality improvements and dependency updates. It enhances error handling throughout the application, fixes a spelling mistake in method names, optimizes return types, and updates numerous dependencies to their latest versions.

Changes:

  • Improved error handling with better error propagation in async tasks and more descriptive error messages
  • Fixed typo: renamed is_op_poke_challangeble to is_op_poke_challengeable across the codebase
  • Optimized Event::title() return type from String to &'static str to avoid allocations
  • Extracted magic numbers to named constants for better maintainability
  • Updated dependencies including alloy (1.0 → 1.6), tokio, metrics, and many others

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/main.rs Enhanced error handling with constants extraction, proper error propagation in spawned tasks, and better handling of wallet/port configuration errors
crates/scribe/src/provider.rs Improved error message clarity with expect() instead of unwrap()
crates/scribe/src/events_poller.rs Changed panic to error return for missing channel, added error handling continuation
crates/scribe/src/event_processor.rs Fixed typo in method name, changed return type to Result for proper error propagation, improved error handling
crates/scribe/src/event.rs Optimized title() method to return &'static str instead of String
crates/scribe/src/error.rs Reorganized error variants, added MissingBlockNumber and ChannelNotFound errors, improved error messages
crates/scribe/src/contract.rs Added wrap_contract_error helper method, fixed typo in method name, improved error handling
Cargo.toml Updated workspace dependencies to latest versions, removed unused testing_logger
Cargo.lock Lockfile updates reflecting dependency version changes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread crates/scribe/src/contract.rs
Comment thread src/main.rs Outdated
konstantinzolotarev and others added 2 commits February 11, 2026 19:38
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants