Skip to content

Code fixes + dependencies upgrade#31

Merged
konstantinzolotarev merged 9 commits into
mainfrom
sc-16027-upgrade-outdated-dependencies-for
Mar 15, 2026
Merged

Code fixes + dependencies upgrade#31
konstantinzolotarev merged 9 commits into
mainfrom
sc-16027-upgrade-outdated-dependencies-for

Conversation

@konstantinzolotarev
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the challenger and scribe crates to improve runtime robustness (error handling, task supervision) while upgrading core dependencies.

Changes:

  • Upgraded workspace dependencies (alloy, chrono, env_logger, tokio-util, mockall, etc.).
  • Improved error handling in main (wallet required, address parsing), poller/processor failure propagation, and logging.
  • Refactored/cleaned up contract error handling and added/expanded test coverage around poller/processor behavior.

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
src/main.rs Adds constants, improves input validation, logging, and task supervision/error propagation.
crates/scribe/src/provider.rs Replaces unwrap() with expect() for clearer test-only URL parse failures.
crates/scribe/src/events_poller.rs Avoids panics on missing channels, continues on per-log failures, adds tests.
crates/scribe/src/event_processor.rs Fixes naming typo, makes start() fallible, improves error propagation and tests.
crates/scribe/src/event.rs Changes Event::title() to return &'static str (API change) to avoid allocations.
crates/scribe/src/error.rs Refines/extends error types (new variants, moved/removed variants).
crates/scribe/src/contract.rs Adds helper for address-context errors, improves missing block-number handling, adds tests.
Cargo.toml Dependency upgrades across the workspace and root crate.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/main.rs
Comment thread src/main.rs
Comment thread crates/scribe/src/event.rs
Comment thread crates/scribe/src/contract.rs Outdated
Comment thread crates/scribe/src/events_poller.rs Outdated
Comment thread crates/scribe/src/contract.rs Outdated
@konstantinzolotarev konstantinzolotarev merged commit bb4f785 into main Mar 15, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants