Code fixes + dependencies upgrade#31
Merged
konstantinzolotarev merged 9 commits intoMar 15, 2026
Merged
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the challenger and scribe crates to improve runtime robustness (error handling, task supervision) while upgrading core dependencies.
Changes:
- Upgraded workspace dependencies (alloy, chrono, env_logger, tokio-util, mockall, etc.).
- Improved error handling in
main(wallet required, address parsing), poller/processor failure propagation, and logging. - Refactored/cleaned up contract error handling and added/expanded test coverage around poller/processor behavior.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/main.rs | Adds constants, improves input validation, logging, and task supervision/error propagation. |
| crates/scribe/src/provider.rs | Replaces unwrap() with expect() for clearer test-only URL parse failures. |
| crates/scribe/src/events_poller.rs | Avoids panics on missing channels, continues on per-log failures, adds tests. |
| crates/scribe/src/event_processor.rs | Fixes naming typo, makes start() fallible, improves error propagation and tests. |
| crates/scribe/src/event.rs | Changes Event::title() to return &'static str (API change) to avoid allocations. |
| crates/scribe/src/error.rs | Refines/extends error types (new variants, moved/removed variants). |
| crates/scribe/src/contract.rs | Adds helper for address-context errors, improves missing block-number handling, adds tests. |
| Cargo.toml | Dependency upgrades across the workspace and root crate. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.