Skip to content

Commit 2c1cdc4

Browse files
committed
Allow to customize WebSocket UPGRADE response in OnWsConnecting()
1 parent 62abea6 commit 2c1cdc4

11 files changed

Lines changed: 9 additions & 9 deletions

File tree

examples/WsChatClient/Program.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ public override void OnWsConnecting(HttpRequest request)
2828
request.SetHeader("Sec-WebSocket-Key", Convert.ToBase64String(WsNonce));
2929
request.SetHeader("Sec-WebSocket-Protocol", "chat, superchat");
3030
request.SetHeader("Sec-WebSocket-Version", "13");
31-
request.SetBody();
3231
}
3332

3433
public override void OnWsConnected(HttpResponse response)

examples/WssChatClient/Program.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ public override void OnWsConnecting(HttpRequest request)
3030
request.SetHeader("Sec-WebSocket-Key", Convert.ToBase64String(WsNonce));
3131
request.SetHeader("Sec-WebSocket-Protocol", "chat, superchat");
3232
request.SetHeader("Sec-WebSocket-Version", "13");
33-
request.SetBody();
3433
}
3534

3635
public override void OnWsConnected(HttpResponse response)

performance/WsEchoClient/Program.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ public override void OnWsConnecting(HttpRequest request)
2424
request.SetHeader("Sec-WebSocket-Key", Convert.ToBase64String(WsNonce));
2525
request.SetHeader("Sec-WebSocket-Protocol", "chat, superchat");
2626
request.SetHeader("Sec-WebSocket-Version", "13");
27-
request.SetBody();
2827
}
2928

3029
public override void OnWsConnected(HttpResponse response)

performance/WsMulticastClient/Program.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ public override void OnWsConnecting(HttpRequest request)
2121
request.SetHeader("Sec-WebSocket-Key", Convert.ToBase64String(WsNonce));
2222
request.SetHeader("Sec-WebSocket-Protocol", "chat, superchat");
2323
request.SetHeader("Sec-WebSocket-Version", "13");
24-
request.SetBody();
2524
}
2625

2726
public override void OnWsReceived(byte[] buffer, long offset, long size)

performance/WssEchoClient/Program.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ public override void OnWsConnecting(HttpRequest request)
2626
request.SetHeader("Sec-WebSocket-Key", Convert.ToBase64String(WsNonce));
2727
request.SetHeader("Sec-WebSocket-Protocol", "chat, superchat");
2828
request.SetHeader("Sec-WebSocket-Version", "13");
29-
request.SetBody();
3029
}
3130

3231
public override void OnWsConnected(HttpResponse response)

performance/WssMulticastClient/Program.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ public override void OnWsConnecting(HttpRequest request)
2323
request.SetHeader("Sec-WebSocket-Key", Convert.ToBase64String(WsNonce));
2424
request.SetHeader("Sec-WebSocket-Protocol", "chat, superchat");
2525
request.SetHeader("Sec-WebSocket-Version", "13");
26-
request.SetBody();
2726
}
2827

2928
public override void OnWsReceived(byte[] buffer, long offset, long size)

source/NetCoreServer/WebSocket.cs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -232,12 +232,14 @@ public bool PerformServerUpgrade(HttpRequest request, HttpResponse response)
232232
response.SetHeader("Connection", "Upgrade");
233233
response.SetHeader("Upgrade", "websocket");
234234
response.SetHeader("Sec-WebSocket-Accept", accept);
235-
response.SetBody();
236235

237236
// Validate WebSocket upgrade request and response
238237
if (!_wsHandler.OnWsConnecting(request, response))
239238
return false;
240239

240+
// Set body of the WebSocket upgrade response
241+
response.SetBody();
242+
241243
// Send WebSocket upgrade response
242244
_wsHandler.SendUpgrade(response);
243245

source/NetCoreServer/WsClient.cs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -292,6 +292,9 @@ protected override void OnConnected()
292292
// Fill the WebSocket upgrade HTTP request
293293
OnWsConnecting(Request);
294294

295+
// Set body of the WebSocket upgrade HTTP request
296+
Request.SetBody();
297+
295298
// Send the WebSocket upgrade HTTP request
296299
if (_syncConnect)
297300
SendRequest(Request);

source/NetCoreServer/WssClient.cs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -296,6 +296,9 @@ protected override void OnHandshaked()
296296
// Fill the WebSocket upgrade HTTP request
297297
OnWsConnecting(Request);
298298

299+
// Set body of the WebSocket upgrade HTTP request
300+
Request.SetBody();
301+
299302
// Send the WebSocket upgrade HTTP request
300303
if (_syncConnect)
301304
SendRequest(Request);

tests/WsTests.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ public override void OnWsConnecting(HttpRequest request)
2828
request.SetHeader("Sec-WebSocket-Key", Convert.ToBase64String(WsNonce));
2929
request.SetHeader("Sec-WebSocket-Protocol", "chat, superchat");
3030
request.SetHeader("Sec-WebSocket-Version", "13");
31-
request.SetBody();
3231
}
3332
public override void OnWsConnected(HttpResponse response) { IsWsConnected = true; Connected = true; }
3433
public override void OnWsDisconnected() { IsWsConnected = false; Disconnected = true; }

0 commit comments

Comments
 (0)