be more precise about deprecation testing

Author: dominikzogg

tests/Unit/Schema/StringSchemaTest.php

@@ -556,13 +556,11 @@ public function testParseWithMatchWithInvalidPattern(): void
 
     public function testParseWithValidMatch(): void
     {
-        error_clear_last();
-
         $input = 'aBcDeFg';
 
-        $schema = (new StringSchema())->match('/^[a-z]+$/i');
+        error_clear_last();
 
-        self::assertSame($input, $schema->parse($input));
+        $schema = (new StringSchema())->match('/^[a-z]+$/i');
 
         $lastError = error_get_last();
 
@@ -571,6 +569,8 @@ public function testParseWithValidMatch(): void
         self::assertSame(E_USER_DEPRECATED, $lastError['type']);
         self::assertArrayHasKey('message', $lastError);
         self::assertSame('Use pattern instead', $lastError['message']);
+
+        self::assertSame($input, $schema->parse($input));
     }
 
     public function testParseWithInvalidMatch(): void
@@ -660,13 +660,11 @@ public function testParseWithRegexpWithInvalidPattern(): void
 
     public function testParseWithValidRegexp(): void
     {
-        error_clear_last();
-
         $input = 'aBcDeFg';
 
-        $schema = (new StringSchema())->regexp('/^[a-z]+$/i');
+        error_clear_last();
 
-        self::assertSame($input, $schema->parse($input));
+        $schema = (new StringSchema())->regexp('/^[a-z]+$/i');
 
         $lastError = error_get_last();
 
@@ -675,6 +673,8 @@ public function testParseWithValidRegexp(): void
         self::assertSame(E_USER_DEPRECATED, $lastError['type']);
         self::assertArrayHasKey('message', $lastError);
         self::assertSame('Use pattern instead', $lastError['message']);
+
+        self::assertSame($input, $schema->parse($input));
     }
 
     public function testParseWithInvalidRegexp(): void