there is no need for an iterator in the current implementation

Author: dominikzogg

src/Pet/Dto/Collection/PetCollectionResponse.php

@@ -12,8 +12,6 @@
  * @property PetCollectionSort    $sort
  * @property array<PetResponse>   $items
  *
- * @implements \IteratorAggregate<string, mixed>
- *
  * @phpstan-type JsonSerializedResult array{
  *   offset: int,
  *   limit: int,
@@ -50,7 +48,7 @@
  *
  * @method JsonSerializedResult jsonSerialize()
  */
-final readonly class PetCollectionResponse extends AbstractReadonlyCollectionResponse implements \IteratorAggregate
+final readonly class PetCollectionResponse extends AbstractReadonlyCollectionResponse
 {
     public function __construct(
         int $offset,
@@ -73,9 +71,4 @@ public function __construct(
             $_links,
         );
     }
-
-    public function getIterator(): \Traversable
-    {
-        return new \ArrayIterator(get_object_vars($this));
-    }
 }

src/Pet/Dto/Model/PetResponse.php

@@ -6,10 +6,7 @@
 
 use Chubbyphp\Api\Dto\Model\ModelResponseInterface;
 
-/**
- * @implements \IteratorAggregate<string, mixed>
- */
-final readonly class PetResponse implements \IteratorAggregate, ModelResponseInterface
+final readonly class PetResponse implements ModelResponseInterface
 {
     /**
      * @param array<VaccinationResponse> $vaccinations
@@ -65,9 +62,4 @@ public function jsonSerialize(): array
             '_links' => $this->_links,
         ];
     }
-
-    public function getIterator(): \Traversable
-    {
-        return new \ArrayIterator(get_object_vars($this));
-    }
 }

tests/Unit/Pet/Dto/Collection/PetCollectionResponseTest.php

@@ -80,16 +80,5 @@ public function testCreateCollection(): void
             '_type' => 'petCollection',
             '_links' => [],
         ], $petCollectionResponse->jsonSerialize());
-
-        self::assertSame([
-            'offset' => 5,
-            'limit' => 10,
-            'filters' => $petCollectionFilters,
-            'sort' => $petCollectionSort,
-            'items' => [$petResponse],
-            'count' => 1,
-            '_type' => 'petCollection',
-            '_links' => [],
-        ], [...$petCollectionResponse]);
     }
 }

tests/Unit/Pet/Dto/Model/PetResponseTest.php

@@ -46,16 +46,5 @@ public function testCreateCollection(): void
             '_type' => 'pet',
             '_links' => [],
         ], $petResponse->jsonSerialize());
-
-        self::assertSame([
-            'id' => '019c201f-6a83-7696-9899-50fbf7b2278d',
-            'createdAt' => '2024-02-10T18:15:00+00:00',
-            'updatedAt' => '2024-02-10T18:15:00+00:00',
-            'name' => 'jerry',
-            'tag' => 'tag',
-            'vaccinations' => [$vaccinationResponse],
-            '_type' => 'pet',
-            '_links' => [],
-        ], [...$petResponse]);
     }
 }