Skip to content

Fix some bugs to get closer to the release #1860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leMaik merged 4 commits into from
Jan 1, 2026
Merged

Fix some bugs to get closer to the release #1860

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d68fa0c
Fix the scenes directory picker not showing up if the scenes director…
leMaik Jan 1, 2026
9d411cb
Do not show the camera tooltip if the window is not focused.
leMaik Jan 1, 2026
2b69ee2
Do not resize the right control panel when resizing the left control …
leMaik Jan 1, 2026
6b86269
Fix entity face camera and face target buttons.
leMaik Jan 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions chunky/src/java/se/llbit/chunky/entity/Poseable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,9 @@ default void lookAt(Vector3 target) {
dir.sub(face);
dir.normalize();
double headYaw = getPose("head").y;
getPose().set("rotation", Json.of(FastMath.atan2(dir.x, dir.z) + Math.PI - headYaw));
double pitch = Math.asin(dir.y);
getPose().add("head", JsonUtil.vec3ToJson(new Vector3(pitch, headYaw, 0)));
getPose().set("head", JsonUtil.vec3ToJson(new Vector3(pitch, 0, 0)));
getPose().set("all", JsonUtil.vec3ToJson(new Vector3(0, FastMath.atan2(dir.x, dir.z) + Math.PI - headYaw, 0)));
}


Expand Down
4 changes: 4 additions & 0 deletions chunky/src/java/se/llbit/chunky/ui/RenderCanvasFx.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,6 +440,10 @@ public void setRenderListener(RenderStatusListener renderListener) {

@Override public void sceneStatus(String status) {
Platform.runLater(() -> {
if (!getScene().getWindow().isFocused()) {
return;
}

Point2D offset = localToScene(0, 0);
tooltip.setText(status);
tooltip.show(this,
Expand Down
9 changes: 6 additions & 3 deletions chunky/src/java/se/llbit/chunky/ui/controller/SceneChooserController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,10 +113,13 @@ public class SceneChooserController implements Initializable {
new Tooltip("Open the directory where Chunky stores scene descriptions and renders."));
openSceneDirBtn.setOnAction(e -> controller.openDirectory(controller.getChunky().options.sceneDir));

DirectoryChooser sceneDirectoryChooser = new DirectoryChooser();
sceneDirectoryChooser.setTitle("Select directory for scene storage");
changeSceneDirBtn.setOnAction(e -> {
sceneDirectoryChooser.setInitialDirectory(controller.getChunky().options.sceneDir);
DirectoryChooser sceneDirectoryChooser = new DirectoryChooser();
sceneDirectoryChooser.setTitle("Select directory for scene storage");
File sceneDirectory = controller.getChunky().options.sceneDir;
if (sceneDirectory.isDirectory()) {
sceneDirectoryChooser.setInitialDirectory(sceneDirectory);
}
File directory = sceneDirectoryChooser.showDialog(changeSceneDirBtn.getScene().getWindow());
if(directory != null && directory.canWrite()) {
PersistentSettings.setSceneDirectory(directory);
Expand Down
2 changes: 1 addition & 1 deletion chunky/src/res/se/llbit/chunky/ui/Chunky.fxml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
<Canvas fx:id="mapCanvas" />
<Canvas fx:id="mapOverlay" />
</StackPane>
<VBox maxWidth="500" minWidth="0" spacing="10.0">
<VBox maxWidth="500" minWidth="0" spacing="10.0" SplitPane.resizableWithParent="false">
<padding>
<Insets bottom="10.0" left="10.0" right="10.0" top="10.0"/>
</padding>
Expand Down