From 7eab3e2486caa7690de11ad16d754ea156e1fd9e Mon Sep 17 00:00:00 2001
From: Maik Marschner <m.marschner@wertarbyte.com>
Date: Thu, 16 Jul 2026 22:40:43 +0200
Subject: [PATCH] Fix biome texture being empty if any chunk has no blocks that
 are affected by the biome.

---
 .../se/llbit/chunky/renderer/scene/Scene.java | 28 ++++---------------
 1 file changed, 6 insertions(+), 22 deletions(-)

diff --git a/chunky/src/java/se/llbit/chunky/renderer/scene/Scene.java b/chunky/src/java/se/llbit/chunky/renderer/scene/Scene.java
index aa5eaab4e..bc4bc6bf6 100644
--- a/chunky/src/java/se/llbit/chunky/renderer/scene/Scene.java
+++ b/chunky/src/java/se/llbit/chunky/renderer/scene/Scene.java
@@ -1353,14 +1353,6 @@ public synchronized void loadChunks(TaskTracker taskTracker, World world, Map<Re
                 dryFoliageTexture,
                 waterTexture);
             }
-
-            // TODO we could skip blending the grass, foliage and dry foliage textures in this case
-            if (!biomeUsed) {
-              grassTexture = biomeStructureFactory.create();
-              foliageTexture = biomeStructureFactory.create();
-              dryFoliageTexture = biomeStructureFactory.create();
-              // the water texture is still used to check for loaded chunks and tint the water plane
-            }
           } else {
             BiomeBlendingUtility.chunk2DBlur(
               cp,
@@ -1374,14 +1366,6 @@ public synchronized void loadChunks(TaskTracker taskTracker, World world, Map<Re
               foliageTexture,
               dryFoliageTexture,
               waterTexture);
-
-            // TODO we could skip blending the grass, foliage and dry foliage textures in this case
-            if (!biomeUsed) {
-              grassTexture = biomeStructureFactory.create();
-              foliageTexture = biomeStructureFactory.create();
-              dryFoliageTexture = biomeStructureFactory.create();
-              // the water texture is still used to check for loaded chunks and tint the water plane
-            }
           }
         } else {
           if(use3dBiomes) {
@@ -1396,12 +1380,12 @@ public synchronized void loadChunks(TaskTracker taskTracker, World world, Map<Re
                     int id = biomePaletteIdxStructure.get(wx, wy, wz);
 
                     Biome biome = biomePalette.get(id);
-                  if (biomeUsed) {
-                    grassTexture.set(cp.x * 16 + x - origin.x, sectionY * 16 + y - origin.y, cp.z * 16 + z - origin.z, biome.grassColorLinear);
-                    foliageTexture.set(cp.x * 16 + x - origin.x, sectionY * 16 + y - origin.y, cp.z * 16 + z - origin.z, biome.foliageColorLinear);
-                    dryFoliageTexture.set(cp.x * 16 + x - origin.x, sectionY * 16 + y - origin.y, cp.z * 16 + z - origin.z, biome.dryFoliageColorLinear);
-                  }
-                  // the water texture is used to check for loaded chunks and tint the water plane, so we always need that one
+                    if (biomeUsed) {
+                      grassTexture.set(cp.x * 16 + x - origin.x, sectionY * 16 + y - origin.y, cp.z * 16 + z - origin.z, biome.grassColorLinear);
+                      foliageTexture.set(cp.x * 16 + x - origin.x, sectionY * 16 + y - origin.y, cp.z * 16 + z - origin.z, biome.foliageColorLinear);
+                      dryFoliageTexture.set(cp.x * 16 + x - origin.x, sectionY * 16 + y - origin.y, cp.z * 16 + z - origin.z, biome.dryFoliageColorLinear);
+                    }
+                    // the water texture is used to check for loaded chunks and tint the water plane, so we always need that one
                     waterTexture.set(cp.x * 16 + x - origin.x, sectionY * 16 + y - origin.y, cp.z * 16 + z - origin.z, biome.waterColorLinear);
                   }
                 }