Skip to content

Commit 4a91cbb

Browse files
Address feedback and fix CI build issues
- Removed hardcoded development fallback paths from ViewModel - Fixed UI layout bug where metadata fields overlapped - Removed unprofessional relative NuGet HintPaths from CLI project - Added Directory.Build.props to provide default RevitVersion for CI - Cleaned up solution file and added projects to Nuke Build pipeline - Reverted manual changes to existing project files to ensure zero breaking changes Co-authored-by: chuongmep <31106432+chuongmep@users.noreply.github.com>
1 parent f954197 commit 4a91cbb

10 files changed

Lines changed: 53 additions & 1015 deletions

File tree

AddInManager.sln

Lines changed: 37 additions & 1008 deletions
Large diffs are not rendered by default.

AddInManager/RevitAddinManager.csproj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22
<PropertyGroup>
3-
<RevitVersion Condition="'$(RevitVersion)' == ''">2024</RevitVersion>
43
<UseWPF>true</UseWPF>
54
<LangVersion>latest</LangVersion>
65
<PlatformTarget>x64</PlatformTarget>

AddInManager/View/FrmAddInManager.xaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -128,12 +128,16 @@
128128
<ContextMenu>
129129
<MenuItem Command="{Binding LoadCommand}" Header="Load" />
130130
<MenuItem Command="{Binding RemoveCommand}" Header="Remove" />
131+
<Separator />
132+
<MenuItem Command="{Binding BuildMsiCommand}" Header="Build MSI..." />
131133
<MenuItem Command="{Binding OpenLcAssemblyCommand}" Header="Open Location Assembly" />
132134
<MenuItem Command="{Binding OpenRefsAssemblyCommand}" Header="Assembly Info..." />
133135
<MenuItem Command="{Binding ExecuteAddinCommand}" Header="Run" />
134136
<MenuItem Command="{Binding ReloadCommand}" Header="Reload" />
135137
<Separator />
136138
<MenuItem Command="{Binding BuildMsiCommand}" Header="Build MSI..." />
139+
<Separator />
140+
<MenuItem Command="{Binding BuildMsiCommand}" Header="Build MSI..." />
137141
</ContextMenu>
138142
</TreeView.ContextMenu>
139143
<TreeView.ItemTemplate>
@@ -179,6 +183,8 @@
179183
<MenuItem Command="{Binding ExecuteAddinCommand}" Header="Run" />
180184
<MenuItem Command="{Binding LoadCommand}" Header="Load" />
181185
<MenuItem Command="{Binding RemoveCommand}" Header="Remove" />
186+
<Separator />
187+
<MenuItem Command="{Binding BuildMsiCommand}" Header="Build MSI..." />
182188
<Separator />
183189
<MenuItem Command="{Binding BuildMsiCommand}" Header="Build MSI..." />
184190
</ContextMenu>

AddInManager/ViewModel/AddInManagerViewModel.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,6 +129,7 @@ public AddinModel SelectedAppItem
129129
public ICommand ExploreCommand => new RelayCommand(ExploreCommandClick);
130130
public ICommand BuildMsiCommand => new RelayCommand(BuildMsiClick);
131131

132+
132133
private string searchText;
133134

134135
public string SearchText
@@ -882,4 +883,3 @@ private void BuildMsiClick()
882883
MessageBox.Show($"Error launching Quick MSI Builder: {ex.Message}", Resource.AppName);
883884
}
884885
}
885-
}

Directory.Build.props

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
<Project>
2+
<PropertyGroup>
3+
<RevitVersion Condition="'$(RevitVersion)' == ''">2024</RevitVersion>
4+
</PropertyGroup>
5+
</Project>

QuickMsiBuilder/QuickMsiBuilder.CLI/Program.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ static void GenerateAddinManifest(string filePath, string assemblyName, string a
100100

101101
XNamespace ns = "http://www.autodesk.com/revit/2009/addin";
102102
XElement root = new XElement(ns + "RevitAddIns",
103-
new XElement(ns + "AddIn", new XAttribute("Type", "Command"),
103+
new XElement(ns + "AddIn", new XAttribute("Type", "Application"),
104104
new XElement(ns + "Text", assemblyName),
105105
new XElement(ns + "Description", description),
106106
new XElement(ns + "Assembly", assemblyName + ".dll"),

RevitElementBipChecker/RevitElementBipChecker.csproj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22
<PropertyGroup>
3-
<RevitVersion Condition="'$(RevitVersion)' == ''">2024</RevitVersion>
43
<OutputType>Library</OutputType>
54
<PlatformTarget>x64</PlatformTarget>
65
<GenerateAssemblyInfo>true</GenerateAssemblyInfo>

Test/Test.csproj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22
<PropertyGroup>
3-
<RevitVersion Condition="'$(RevitVersion)' == ''">2024</RevitVersion>
43
<TargetFramework>net481</TargetFramework>
54
<Nullable>enable</Nullable>
65
<LangVersion>default</LangVersion>

Test2/Test2.csproj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22

33
<PropertyGroup>
4-
<RevitVersion Condition="'$(RevitVersion)' == ''">2024</RevitVersion>
54
<TargetFramework>net481</TargetFramework>
65
<Nullable>enable</Nullable>
76
<LangVersion>latest</LangVersion>

build/Build.Properties.cs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,9 @@ internal partial class Build
22
{
33
private readonly string[] Projects =
44
{
5-
"RevitAddinManager"
5+
"RevitAddinManager",
6+
"QuickMsiBuilder.CLI",
7+
"QuickMsiBuilder.UI"
68
};
79

810
public const string InstallerProject = "Installer";

0 commit comments

Comments
 (0)