fix(mqtt): correct HA state topics and allow DEVICE_NAME env override

The HA discovery config for the Confidence and Detection Time sensors
declared state_topics using an underscore (clouddetect_<id>_confidence)
that did not match where publish_states() actually publishes
(clouddetect_<id>/confidence). The sensors never received state. Aligned
the config state_topics to use the slash form so they match.

Also set AlpacaConfig.device_name default to an empty string so
resolve_detect_overrides()'s pick() falls through to the DEVICE_NAME
env var. The non-empty static default previously masked the env var.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: chvvkumar

alpaca/config.py

@@ -61,7 +61,7 @@ class AlpacaConfig:
     """Configuration for the Alpaca server"""
     port: int = 11111
     device_number: int = 0
-    device_name: str = "SimpleCloudDetect"
+    device_name: str = ""
     device_description: str = "ASCOM SafetyMonitor based on ML cloud detection"
     driver_info: str = "ASCOM Alpaca SafetyMonitor v2.0 - Cloud Detection Driver"
     driver_version: str = "2.0"

detect.py

@@ -127,7 +127,7 @@ def publish_discovery_configs(self):
         confidence_config = {
             "name": "Confidence",
             "unique_id": f"clouddetect_{self.device_id}_confidence",
-            "state_topic": f"{self.discovery_prefix}/sensor/clouddetect_{self.device_id}_confidence/state",
+            "state_topic": f"{self.discovery_prefix}/sensor/clouddetect_{self.device_id}/confidence/state",
             "availability_topic": self.availability_topic,
             "unit_of_measurement": "%",
             "icon": "mdi:percent",
@@ -143,7 +143,7 @@ def publish_discovery_configs(self):
         time_config = {
             "name": "Detection Time",
             "unique_id": f"clouddetect_{self.device_id}_detection_time",
-            "state_topic": f"{self.discovery_prefix}/sensor/clouddetect_{self.device_id}_detection_time/state",
+            "state_topic": f"{self.discovery_prefix}/sensor/clouddetect_{self.device_id}/detection_time/state",
             "availability_topic": self.availability_topic,
             "unit_of_measurement": "s",
             "device_class": "duration",