Skip to content

Commit 230bae8

Browse files
authored
Remove parameter @dir on content component (#1036)
* Remove option to pass parameter `@dir` to BasicDropdownContent * Add change in docs
1 parent a984c7e commit 230bae8

2 files changed

Lines changed: 8 additions & 3 deletions

File tree

docs/app/templates/public-pages/docs/migrate-8-0-to-9-0.gts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,14 @@ import { LinkTo } from '@ember/routing';
5252
Note: This option was never documented.
5353
</p>
5454
</li>
55+
<li>
56+
<p>
57+
Passing
58+
<code>@dir</code>
59+
to the content component has been removed. Please pass this parameter as
60+
a regular HTML attribute instead.
61+
</p>
62+
</li>
5563
<li>
5664
<p>
5765
If you are using

ember-basic-dropdown/src/components/basic-dropdown-content.gts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@ export interface BasicDropdownContentSignature {
4545
otherStyles?: Record<string, string | number | undefined>;
4646
hPosition?: HorizontalPosition | null;
4747
vPosition?: VerticalPosition | null;
48-
dir?: string;
4948
defaultClass?: string;
5049
overlay?: boolean;
5150
htmlTag?: keyof HTMLElementTagNameMap;
@@ -554,7 +553,6 @@ export default class BasicDropdownContent extends Component<BasicDropdownContent
554553
' ember-basic-dropdown-content--in-place'
555554
}}
556555
{{@defaultClass}}"
557-
dir={{@dir}}
558556
...attributes
559557
{{style @otherStyles this.positionStyles}}
560558
{{this.respondToEvents}}
@@ -586,7 +584,6 @@ export default class BasicDropdownContent extends Component<BasicDropdownContent
586584
' ember-basic-dropdown-content--in-place'
587585
}}
588586
{{@defaultClass}}"
589-
dir={{@dir}}
590587
...attributes
591588
{{style @otherStyles this.positionStyles}}
592589
{{this.respondToEvents}}

0 commit comments

Comments
 (0)