Skip to content

Commit fd716b8

Browse files
authored
Remove type reexport (#1054)
* Remove type reexport * Fix type import * run format * Fix type import
1 parent f1df213 commit fd716b8

File tree

3 files changed

+7
-8
lines changed

3 files changed

+7
-8
lines changed

docs/app/components/snippets/dropdown-events-2.gts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,8 @@
11
import Component from '@glimmer/component';
22
import { action } from '@ember/object';
33
import { task, timeout } from 'ember-concurrency';
4-
import BasicDropdown, {
5-
type Dropdown,
6-
} from 'ember-basic-dropdown/components/basic-dropdown';
4+
import BasicDropdown from 'ember-basic-dropdown/components/basic-dropdown';
5+
import type { Dropdown } from 'ember-basic-dropdown/types';
76

87
const users = [
98
{ name: 'Nathan', assignment: 'CLI' },

src/components/basic-dropdown-trigger.gts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,11 @@ import { concat } from '@ember/helper';
66
import basicDropdownTriggerModifier from '../modifiers/basic-dropdown-trigger.ts';
77
import { on } from '@ember/modifier';
88
import { fn } from '@ember/helper';
9-
import type { Dropdown } from './basic-dropdown';
10-
import type { HorizontalPosition, VerticalPosition } from '../types.ts';
9+
import type {
10+
Dropdown,
11+
HorizontalPosition,
12+
VerticalPosition,
13+
} from '../types.ts';
1114

1215
export interface BasicDropdownTriggerSignature<
1316
T extends keyof HTMLElementTagNameMap = 'div',

src/components/basic-dropdown.gts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,6 @@ import type {
2727
TRootEventType,
2828
} from '../types.ts';
2929

30-
// To avoid breaking the current types export we need this
31-
export type { Dropdown, DropdownActions, TRootEventType };
32-
3330
const UNINITIALIZED = {};
3431
const IGNORED_STYLES = ['top', 'left', 'right', 'width', 'height'];
3532

0 commit comments

Comments
 (0)