Remove dropdown option from calculatePosition#1031
Merged
Conversation
mkszepp
changed the title
dropdown option from calculatePosition
mkszepp
deleted the
drop-passing-component-class-to-calculate-position
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since version 3.x, we have been passing the
dropdownclass instance (thisreference) tocalculatePosition.This allowed custom
calculatePositionto access all non-private getters and functions of the class.However, there is no valid reason for it to access all internal getters and functions.
If additional helpers or functionality are needed, we should extend the public API instead.