Omit redundant preset degrees from URLs

Author: ciembor

src/services/SchemeUrlState.js

@@ -399,13 +399,17 @@ export function buildSchemeQueryParams(scheme) {
   const params = new URLSearchParams();
   const defaults = createDefaultScheme();
   const hueSet = resolvedHueSet(scheme);
+  const presetDegrees = hueSet ? degreesForHueSet(hueSet, scheme.hueDistance) : null;
+  const hasRedundantDegrees = presetDegrees && sameValue(scheme.degrees, presetDegrees);
 
   setParamIfChanged(params, 'hue', scheme.hue, defaults.hue);
   if (hueSet && hueSet !== defaults.hueSet) {
     params.set('hueSet', hueSet);
   }
   setParamIfChanged(params, 'hueDistance', scheme.hueDistance, defaults.hueDistance);
-  setParamIfChanged(params, 'degrees', scheme.degrees, defaults.degrees);
+  if (!hasRedundantDegrees) {
+    setParamIfChanged(params, 'degrees', scheme.degrees, defaults.degrees);
+  }
   setParamIfChanged(params, 'saturation', scheme.saturation, defaults.saturation);
   setParamIfChanged(params, 'saturationRange', scheme.saturationRange, defaults.saturationRange);
   setParamIfChanged(

tests/SchemeUrlState.test.js

@@ -54,6 +54,17 @@ describe('SchemeUrlState', () => {
     expect(buildSchemeSearch(createDefaultScheme())).toBe('');
   });
 
+  it('omits degrees when they are implied by hue-set and hue-distance', () => {
+    const scheme = createDefaultScheme();
+
+    scheme.hue = 12;
+    scheme.hueSet = 'duotone';
+    scheme.hueDistance = 18;
+    scheme.degrees = degreesForHueSet('duotone', 18);
+
+    expect(buildSchemeSearch(scheme)).toBe('?hue=12&hueSet=duotone&hueDistance=18');
+  });
+
   it('roundtrips a custom scheme through the query string', () => {
     const scheme = createDefaultScheme();
 

tests/SocialShare.test.js

@@ -18,7 +18,7 @@ describe('SocialShare', () => {
       origin: 'https://ciembor.github.io',
       pathname: '/4bit/',
     })).toBe(
-      'https://ciembor.github.io/4bit/?hue=12&hueSet=duotone&hueDistance=18&degrees=0,18,180,198,162,342'
+      'https://ciembor.github.io/4bit/?hue=12&hueSet=duotone&hueDistance=18'
     );
   });