Fix badge URLs and restore ranking podiums

Author: ciembor

app/public/css/components/rankings.css

@@ -355,6 +355,18 @@
   color: var(--accent-strong);
 }
 
+.second_place {
+  background: linear-gradient(130deg, #bbb 0%, #eee 50%);
+}
+
+.first_place {
+  background: linear-gradient(130deg, #d4af37 0%, #fff3b0 50%);
+}
+
+.third_place {
+  background: linear-gradient(130deg, #b87333 0%, #ffd1a3 50%);
+}
+
 .metric {
   color: var(--accent);
   font-weight: 900;

app/views/languages/ranking_table.erb

@@ -3,7 +3,8 @@
   <% if rows.any? %>
     <ol class="ranking-list" aria-labelledby="<%= h heading_id %>">
       <% rows.each_with_index do |row, index| %>
-        <li class="ranking-list__item">
+        <% place_class = { 1 => "first_place", 2 => "second_place", 3 => "third_place" }[index + 1] %>
+        <li class="ranking-list__item<% if place_class %> <%= h place_class %><% end %>">
           <span class="rank-cell rank-mark"><%= index + 1 %></span>
           <div class="ranking-list__body">
             <div class="ranking-list__title">

app/views/languages/repository_ranking_table.erb

@@ -3,11 +3,12 @@
   <% if rows.any? %>
     <ol class="ranking-list" aria-labelledby="<%= h heading_id %>">
       <% rows.each_with_index do |row, index| %>
+        <% place_class = { 1 => "first_place", 2 => "second_place", 3 => "third_place" }[index + 1] %>
         <% repository = { platform: row.fetch(:platform), full_name: row.fetch(:full_name) } %>
         <% path = row.fetch(:repository_kind) == "organization" ? organization_repository_profile_path(repository) : repository_profile_path(repository) %>
         <% owner = { platform: row.fetch(:platform), login: row.fetch(:owner_login) } %>
         <% owner_path = row.fetch(:repository_kind) == "organization" ? organization_profile_path(owner) : user_profile_path(owner) %>
-        <li class="ranking-list__item">
+        <li class="ranking-list__item<% if place_class %> <%= h place_class %><% end %>">
           <span class="rank-cell rank-mark"><%= index + 1 %></span>
           <div class="ranking-list__body">
             <div class="ranking-list__title">

app/views/packages/ranking_table.erb

@@ -3,12 +3,13 @@
   <% if rows.any? %>
     <ol class="ranking-list" aria-labelledby="<%= h heading_id %>">
       <% rows.each_with_index do |row, index| %>
+        <% place_class = { 1 => "first_place", 2 => "second_place", 3 => "third_place" }[index + 1] %>
         <% registry_url = safe_external_url(row[:registry_url]) %>
         <% repository_profile_url = package_repository_profile_link(row) %>
         <% repository_source_url = package_repository_link(row) %>
         <% owner_profile_url = package_owner_profile_link(row) %>
         <% owner_login = package_owner_login(row) %>
-        <li class="ranking-list__item">
+        <li class="ranking-list__item<% if place_class %> <%= h place_class %><% end %>">
           <span class="rank-cell rank-mark"><%= index + 1 %></span>
           <div class="ranking-list__body">
             <div class="ranking-list__title">

app/views/rankings/table.erb

@@ -3,7 +3,8 @@
   <% if rows.any? %>
     <ol class="ranking-list" aria-labelledby="<%= h heading_id %>">
       <% rows.each_with_index do |row, index| %>
-        <li class="ranking-list__item">
+        <% place_class = { 1 => "first_place", 2 => "second_place", 3 => "third_place" }[index + 1] %>
+        <li class="ranking-list__item<% if place_class %> <%= h place_class %><% end %>">
           <span class="rank-cell rank-mark"><%= index + 1 %></span>
           <div class="ranking-list__body">
             <div class="ranking-list__title">

lib/polish_open_source_rank/web/presentation/badge_helpers.rb

@@ -5,15 +5,21 @@ module Web
     module Presentation
       module BadgeHelpers
         def repository_badge_path(repository)
-          "#{repository_profile_path(repository).sub('/repositories/', '/badges/repositories/')}.svg"
+          platform = Rack::Utils.escape_path(repository.fetch(:platform, 'github'))
+          owner, name = repository.fetch(:full_name).split('/', 2)
+          "/badges/repositories/#{platform}/#{Rack::Utils.escape_path(owner)}/#{Rack::Utils.escape_path(name)}.svg"
         end
 
         def user_badge_path(user)
-          "#{user_profile_path(user).sub('/users/', '/badges/users/')}.svg"
+          platform = Rack::Utils.escape_path(user.fetch(:platform, 'github'))
+          login = Rack::Utils.escape_path(user.fetch(:login))
+          "/badges/users/#{platform}/#{login}.svg"
         end
 
         def organization_badge_path(organization)
-          "#{organization_profile_path(organization).sub('/organizations/', '/badges/organizations/')}.svg"
+          platform = Rack::Utils.escape_path(organization.fetch(:platform, 'github'))
+          login = Rack::Utils.escape_path(organization.fetch(:login))
+          "/badges/organizations/#{platform}/#{login}.svg"
         end
 
         def linked_badge_markdown(alt, badge_path)

spec/polish_open_source_rank/web/app_spec.rb

@@ -653,6 +653,12 @@ def user(_access_token)
 
     github_callback = sign_in_with_github(request)
     profile = request.get('/users/github/alice/alice-example', 'HTTP_COOKIE' => cookie_header(github_callback))
+    expect(profile.body).to include(
+      '[![Badge Polish Open Source](https://rank.example/badges/users/github/alice.svg)]' \
+      '(https://rank.example/people)'
+    )
+    expect(profile.body).not_to include('/badges/users/github/alice/alice-example.svg')
+
     delete = request.post(
       '/users/github/alice/alice-example/delete',
       'HTTP_COOKIE' => cookie_header(profile),
@@ -1572,7 +1578,9 @@ def expect_latest_user_ranking_page(response)
     podium_classes = html_elements(response.body, "//ol[@aria-labelledby='ranking-detail-users']/li")
                      .first(3)
                      .map { |element| element.attributes['class'] }
-    expect(podium_classes).to all(eq('ranking-list__item'))
+    expect(podium_classes).to eq(
+      ['ranking-list__item first_place', 'ranking-list__item second_place', 'ranking-list__item third_place']
+    )
     expect(response.body).not_to include('<table>')
   end
 

spec/polish_open_source_rank/web/presentation/badge_helpers_spec.rb

@@ -0,0 +1,21 @@
+# frozen_string_literal: true
+
+RSpec.describe PolishOpenSourceRank::Web::Presentation::BadgeHelpers do
+  subject(:helper_host) do
+    Class.new do
+      include PolishOpenSourceRank::Web::Presentation::BadgeHelpers
+    end.new
+  end
+
+  it 'builds stable badge paths without profile SEO slugs', :aggregate_failures do
+    expect(
+      helper_host.user_badge_path(platform: 'github', login: 'ciembor', name: 'Maciej Ciemborowicz')
+    ).to eq('/badges/users/github/ciembor.svg')
+    expect(
+      helper_host.organization_badge_path(platform: 'github', login: 'acme', name: 'Acme Labs')
+    ).to eq('/badges/organizations/github/acme.svg')
+    expect(
+      helper_host.repository_badge_path(platform: 'github', full_name: 'ciembor/polish-open-source-rank')
+    ).to eq('/badges/repositories/github/ciembor/polish-open-source-rank.svg')
+  end
+end