Render Google tag script directly

ciembor · ciembor · commit d0d92fd372db · 2026-06-07T23:15:43.000+02:00
diff --git a/app/public/js/google_analytics.js b/app/public/js/google_analytics.js
@@ -10,9 +10,4 @@
 
   window.gtag("js", new Date());
   window.gtag("config", measurementId);
-
-  const script = document.createElement("script");
-  script.async = true;
-  script.src = `https://www.googletagmanager.com/gtag/js?id=${encodeURIComponent(measurementId)}`;
-  document.head.appendChild(script);
 })();
diff --git a/app/views/layout.erb b/app/views/layout.erb
@@ -47,7 +47,8 @@
     </script>
     <script defer src="<%= h asset_path('/js/navigation.js') %>"></script>
     <% if google_analytics_measurement_id %>
-      <script defer src="<%= h asset_path('/js/google_analytics.js') %>"></script>
+      <script src="<%= h asset_path('/js/google_analytics.js') %>"></script>
+      <script async src="<%= h google_analytics_script_url %>"></script>
     <% end %>
   </head>
   <body>
diff --git a/lib/polish_open_source_rank/web/presentation/view_helpers.rb b/lib/polish_open_source_rank/web/presentation/view_helpers.rb
@@ -37,6 +37,10 @@ def google_analytics_measurement_id
           measurement_id.empty? ? nil : measurement_id
         end
 
+        def google_analytics_script_url
+          "https://www.googletagmanager.com/gtag/js?#{Rack::Utils.build_query(id: google_analytics_measurement_id)}"
+        end
+
         def number(value)
           value.to_i.to_s.reverse.gsub(/(\d{3})(?=\d)/, '\1 ').reverse
         end
diff --git a/spec/polish_open_source_rank/web/app_spec.rb b/spec/polish_open_source_rank/web/app_spec.rb
@@ -155,6 +155,9 @@ def user(_access_token)
       '<meta name="google-analytics-measurement-id" content="G-ABC123DEF4">'
     )
     expect(with_analytics.body).to include('/js/google_analytics.js')
+    expect(with_analytics.body).to include(
+      '<script async src="https://www.googletagmanager.com/gtag/js?id=G-ABC123DEF4"></script>'
+    )
   end
 
   it 'redirects legacy latest ranking routes to canonical section paths', :aggregate_failures do

Original file line number	Diff line number	Diff line change
`@@ -155,6 +155,9 @@ def user(_access_token)`
`155`	`155`	`'<meta name="google-analytics-measurement-id" content="G-ABC123DEF4">'`
`156`	`156`	`)`
`157`	`157`	`expect(with_analytics.body).to include('/js/google_analytics.js')`
	`158`	`+ expect(with_analytics.body).to include(`
	`159`	`+ '<script async src="https://www.googletagmanager.com/gtag/js?id=G-ABC123DEF4"></script>'`
	`160`	`+ )`
`158`	`161`	`end`
`159`	`162`
`160`	`163`	`it 'redirects legacy latest ranking routes to canonical section paths', :aggregate_failures do`