Fall back for invalid language icons

Author: ciembor

app/public/icons/languages/move.svg

@@ -5,9 +5,8 @@ module Web
     module Presentation
       module LogoIconHelpers
         def logo_icon_exists?(path)
-          PolishOpenSourceRank.root
-                              .join('app/public', path.delete_prefix('/'))
-                              .file?
+          icon_path = PolishOpenSourceRank.root.join('app/public', path.delete_prefix('/'))
+          icon_path.file? && !icon_path.empty?
         end
 
         def logo_icon_initial(value)

lib/polish_open_source_rank/web/presentation/logo_icon_helpers.rb

@@ -13,4 +13,9 @@
       expect(helper.language_initial('bitbake')).to eq('B')
     end
   end
+
+  it 'falls back to the language initial when an icon is unavailable', :aggregate_failures do
+    expect(helper.language_icon_exists?('Move')).to be(false)
+    expect(helper.language_initial('Move')).to eq('M')
+  end
 end

spec/polish_open_source_rank/web/presentation/language_path_helpers_spec.rb

@@ -25,5 +25,16 @@
     it 'returns false when a public icon is missing' do
       expect(helper.logo_icon_exists?('/icons/languages/definitely_missing.svg')).to be(false)
     end
+
+    it 'returns false when a public icon is empty' do
+      Dir.mktmpdir do |directory|
+        icon_path = Pathname(directory).join('app/public/icons/languages/empty.svg')
+        icon_path.dirname.mkpath
+        icon_path.write('')
+        allow(PolishOpenSourceRank).to receive(:root).and_return(Pathname(directory))
+
+        expect(helper.logo_icon_exists?('/icons/languages/empty.svg')).to be(false)
+      end
+    end
   end
 end