BTF: fixed panics during parsing of malformed input#2021
Merged
Conversation
When the string table is missing a null terminator we might panic. This commit checks if `byte.Index` found a `\0` and if it did not, it returns an error instead of panicking. Signed-off-by: Dylan Reimerink <dylan.reimerink@isovalent.com>
We were accessing the buffer to read any remainder bytes based on the header length which is a user supplied value. This could lead to a panic due to out of bounds read. Adding a guard now results in a graceful error instead. Signed-off-by: Dylan Reimerink <dylan.reimerink@isovalent.com>
Fuzzing revealed that a bad ELF file could cause an integer overflow when doing a bounds check. Fixed this by casting two uint32 values to uint64 before adding them together. Signed-off-by: Dylan Reimerink <dylan.reimerink@isovalent.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug reports and fuzzing found a few cases where our BTF parsing logic would panic instead of returning errors when presented with malformed input. This PR fixes the reported issue as well as the two, after these fixes no further issue were found with an hour of fuzzing.
Fixes: #2019