Skip to content

Commit 4ed5214

Browse files
robneurobneu
committed
Merge branch 'develop'
2 parents eb0dd27 + ffe0762 commit 4ed5214

59 files changed

Lines changed: 2185 additions & 921 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎.gitignore‎

Lines changed: 16 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,23 @@
11
.DS_Store
2-
3-
# Sass cache
4-
/.sass-cache
2+
.sass-cache
53

64
# Development files
7-
/node_modules
8-
/bower_components
5+
node_modules
6+
bower_components
97

108
# Development directories
11-
/dist/
12-
/docs/
13-
/logs/
14-
/reports/
15-
/tmp/
9+
release/
10+
docs/
11+
tmp/
12+
13+
# Auto-Generated Files
14+
!images/src/
15+
!images/src/*
16+
!images/src/**/*
17+
languages/*.pot
18+
languages/*.po
1619

1720
# Third-party dependencies
18-
includes/vendor/
21+
includes/vendor/*
22+
js/vendor/*
23+
css/vendor/*

‎.jscsrc‎

Lines changed: 165 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,165 @@
1+
{
2+
"requireSpacesInConditionalExpression": {
3+
"afterTest": true,
4+
"beforeConsequent": true,
5+
"afterConsequent": true,
6+
"beforeAlternate": true
7+
},
8+
"requireSpacesInFunction": {
9+
"beforeOpeningCurlyBrace": true
10+
},
11+
"disallowSpacesInAnonymousFunctionExpression": {
12+
"beforeOpeningRoundBrace": true
13+
},
14+
"requireMultipleVarDecl": "onevar",
15+
"requireSpacesInsideObjectBrackets": "all",
16+
"disallowSpaceAfterObjectKeys": true,
17+
"requireSpaceAfterBinaryOperators": [
18+
"=", "+=", "-=", "*=", "/=", "%=", "<<=", ">>=", ">>>=",
19+
"&=", "|=", "^=", "+=",
20+
21+
"+", "-", "*", "/", "%", "<<", ">>", ">>>", "&",
22+
"|", "^", "&&", "||", "===", "==", ">=",
23+
"<=", "<", ">", "!=", "!=="
24+
],
25+
"requireSpaceBeforeBinaryOperators": [
26+
"=", "+=", "-=", "*=", "/=", "%=", "<<=", ">>=", ">>>=",
27+
"&=", "|=", "^=", "+=",
28+
29+
"+", "-", "*", "/", "%", "<<", ">>", ">>>", "&",
30+
"|", "^", "&&", "||", "===", "==", ">=",
31+
"<=", "<", ">", "!=", "!=="
32+
],
33+
"disallowKeywords": ["with"],
34+
"disallowMultipleLineBreaks": true,
35+
"validateLineBreaks": "LF",
36+
"disallowMixedSpacesAndTabs": "smart",
37+
"disallowTrailingWhitespace": true,
38+
"requireCurlyBraces": [
39+
"if",
40+
"else",
41+
"for",
42+
"while",
43+
"do",
44+
"try",
45+
"catch"
46+
],
47+
"requireSpaceBeforeBlockStatements": true,
48+
"requireParenthesesAroundIIFE": true,
49+
"requireBlocksOnNewline": true,
50+
"requireOperatorBeforeLineBreak": [
51+
"?",
52+
"=",
53+
"+",
54+
"-",
55+
"/",
56+
"*",
57+
"==",
58+
"===",
59+
"!=",
60+
"!==",
61+
">",
62+
">=",
63+
"<",
64+
"<="
65+
],
66+
"requireSpaceBeforeBinaryOperators": [
67+
"?",
68+
"=",
69+
"+",
70+
"-",
71+
"/",
72+
"*",
73+
"==",
74+
"===",
75+
"!=",
76+
"!==",
77+
">",
78+
">=",
79+
"<",
80+
"<="
81+
],
82+
"requireSpaceAfterBinaryOperators": [
83+
"?",
84+
"=",
85+
"+",
86+
"/",
87+
"*",
88+
":",
89+
"==",
90+
"===",
91+
"!=",
92+
"!==",
93+
">",
94+
">=",
95+
"<",
96+
"<="
97+
],
98+
"disallowSpaceBeforeBinaryOperators": [","],
99+
"disallowSpaceAfterBinaryOperators": [],
100+
"disallowSpaceAfterPrefixUnaryOperators": ["++", "--", "+", "-", "~"],
101+
"requireSpaceAfterPrefixUnaryOperators": ["!"],
102+
"disallowSpaceBeforePostfixUnaryOperators": ["++", "--"],
103+
"requireCamelCaseOrUpperCaseIdentifiers": true,
104+
"disallowMultipleLineStrings": true,
105+
"validateQuoteMarks": "'",
106+
"validateIndentation": "\t",
107+
"requireLineFeedAtFileEnd": true,
108+
"requireDotNotation": true,
109+
"disallowNewlineBeforeBlockStatements": true,
110+
"requireSpaceAfterKeywords": [
111+
"do",
112+
"for",
113+
"if",
114+
"else",
115+
"switch",
116+
"case",
117+
"try",
118+
"catch",
119+
"void",
120+
"while",
121+
"with",
122+
"return",
123+
"typeof"
124+
],
125+
"requireSpaceAfterLineComment": true,
126+
"requireSpaceBeforeKeywords": [
127+
"else",
128+
"while",
129+
"catch"
130+
],
131+
"requireSpaceBeforeObjectValues": true,
132+
"requireSpaceBetweenArguments": true,
133+
"requireSpacesInAnonymousFunctionExpression": {
134+
"beforeOpeningCurlyBrace": true
135+
},
136+
"requireSpacesInForStatement": true,
137+
"requireSpacesInsideArrayBrackets": "all",
138+
"requireSpacesInsideParentheses": {
139+
"all": true,
140+
"except": [
141+
"{",
142+
"}",
143+
"[",
144+
"]",
145+
"function"
146+
]
147+
},
148+
"requireYodaConditions": true,
149+
"validateParameterSeparator": ", ",
150+
151+
"disallowTrailingComma": true,
152+
"disallowPaddingNewlinesInBlocks": true,
153+
"disallowEmptyBlocks": true,
154+
"disallowQuotedKeysInObjects": "allButReserved",
155+
"disallowDanglingUnderscores": true,
156+
"requireCommaBeforeLineBreak": true,
157+
"disallowKeywordsOnNewLine": ["else"],
158+
"requireCapitalizedConstructors": true,
159+
"safeContextKeyword": [ "that" ],
160+
"jsDoc": {
161+
"checkParamNames": true,
162+
"checkRedundantParams": true,
163+
"requireParamTypes": true
164+
}
165+
}

‎.jshintrc‎

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
{
2+
"boss": true,
3+
"curly": true,
4+
"eqeqeq": true,
5+
"eqnull": true,
6+
"es3": true,
7+
"expr": true,
8+
"immed": true,
9+
"noarg": true,
10+
"onevar": true,
11+
"quotmark": "single",
12+
"trailing": true,
13+
"undef": true,
14+
"unused": true,
15+
16+
"browser": true,
17+
18+
"globals": {
19+
"_": false,
20+
"Backbone": false,
21+
"jQuery": false,
22+
"JSON": false,
23+
"wp": false
24+
}
25+
}

‎CHANGELOG.md‎

Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,37 @@
1+
## 0.3.0
2+
3+
There are quite a few internal changes in the plugin for this release, plus some nice new features and improvements on the front-end. We've streamlined everything as much as possible and also added support for some languages other than English! Here's a breakdown of everything that's changed:
4+
5+
### New Features
6+
- Automatic captioning for WordPress images and gallery items (Including Jetpack Galleries)
7+
- Spanish language translation
8+
9+
### Enhancements
10+
- Updated [Featherlight](https://github.com/noelboss/featherlight/) to `1.3.3`
11+
- Improved gallery styles on desktop and mobile devices
12+
- Streamlined overall styles
13+
- Added SVG icons for more visual consistency across various platforms
14+
- Simplified the text used in the admin metabox to ease translations (props @toscho)
15+
16+
### Bug Fixes
17+
- Improved handling of images when certain caching plugins are enabled
18+
- Prevented gallery arrows from being hijacked by WP Emoji
19+
- Fixed a bug which allowed multiple light boxes to be opened using keyboard commands
20+
21+
### Developer Stuff
22+
- Reduced overhead by loading language files only when needed (props @toscho)
23+
- Improved the save routine for our admin metabox (props @toscho)
24+
- Added a `wp_featherlight_captions` filter to control auto-captioning. Filter it to false to disable captions.
25+
- Re-structured the plugin's internal code base and deprecated plugin constants
26+
- Added Grunt and Bower the plugin to allow easier updates and releases in the future
27+
28+
### Added Language Support
29+
- German
30+
- Spanish
31+
- French
32+
- Portuguese (Brazil)
33+
- Spanish (Peru)
34+
135
## 0.2.0
236

337
The primary feature in this release is the addition of a visual loader and the automatic lightboxing of external images. In prior versions, only images from the WordPress host domain were lightboxed automatically. This caused some problems with people using a CDN as the URLs were treated as external.

‎README.md‎

Lines changed: 17 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,21 @@
33
An ultra lightweight jQuery lightbox for WordPress images and galleries.
44

55
__Contributors:__ [Robert Neu](https://github.com/robneu)
6-
__Requires:__ WordPress 4.1
7-
__Tested up to:__ WordPress 4.2.2
6+
__Requires:__ WordPress 4.3
7+
__Tested up to:__ WordPress 4.3
88
__License:__ [GPL-2.0+](http://www.gnu.org/licenses/gpl-2.0.html)
99

10-
![Lightbox Popup](https://cloud.githubusercontent.com/assets/2184093/7943642/6885759a-092b-11e5-943c-c9211653a1e4.png)
10+
![nacin-at-loopconf](https://cloud.githubusercontent.com/assets/2184093/9426378/56c32f16-4902-11e5-9e57-75a4620cc51b.png)
1111

1212
## Description ##
1313

14-
WP Featherlight is a WordPress plugin wrapper for the Featherlight jQuery lightbox plugin. When installed, the plugin will automatically display all standard WordPress images and galleries in a simple, minimalistic lightbox popup. It's also possible to load Videos, iframes, and ajax content using WP Featherlight by adding data attributes to your content. For more details on custom content loading, check out the [featherlight documentation](https://github.com/noelboss/featherlight/#usage).
14+
WP Featherlight is a WordPress plugin wrapper for the Featherlight jQuery lightbox plugin. When installed, the plugin will automatically display all standard WordPress images and galleries in a simple, minimalistic lightbox popup.
15+
16+
In order for WordPress images and galleries to be lightboxed, you need to select the "Media File" option when choosing where the thumbnails should link. You can also select the "Custom Link" option if you make sure to link directly to an image file. This should work for any image file even if it's hosted on another website.
17+
18+
![media-file](https://cloud.githubusercontent.com/assets/2184093/9620710/8850a71e-50e3-11e5-8c89-065fdd0d367d.jpg)
19+
20+
It's also possible to load Videos, iframes, and ajax content using WP Featherlight by adding data attributes to your content. For more details on custom content loading, check out the [featherlight documentation](https://github.com/noelboss/featherlight/#usage).
1521

1622
There are no settings for WP Featherlight, so you should be able to install it without needing to configure anything. In the event you don't want a lightbox on certain pages or posts, there is an option to disable it from within the post editor screen.
1723

@@ -25,6 +31,12 @@ If you find a display problem, it may be related to your theme but please [open
2531

2632
The best way to install this plugin is to either [download a copy](https://wordpress.org/plugins/wp-featherlight/) from the WordPress.org repository or search for "WP Featherlight" from your WordPress admin dashboard.
2733

34+
## Developer Notes ##
35+
36+
While there are no options in the plugin, there are some handy filters to modify the default behavior. As of `0.3.0` all images which use the default WordPress captions will also include a caption when the image is lightboxed. To disable this behavior, filter `wp_featherlight_captions` to false.
37+
38+
You can also disable inclusion of the CSS and JavaScript conditionally using filters which can be found in the `/includes/class-scripts.php` file. If you have questions about how any part of the plugin works, please don't hesitate to [open an issue](https://github.com/wpsitecare/wp-featherlight/issues).
39+
2840
## Contributing ##
2941

30-
If you're a developer, the most current version can be found on the [develop branch](https://github.com/wpsitecare/wp-featherlight/tree/develop). Pull requests, issues, and any feedback is more than welcome. If you would like to contribute code, please make your pull requests against the develop branch rather than the master.
42+
If you're a developer, the most current version can be found on the [develop branch](https://github.com/wpsitecare/wp-featherlight/tree/develop). Pull requests, issues, and any feedback are all more than welcome. If you would like to contribute code, please make your pull requests against the develop branch rather than the master.

0 commit comments

Comments
 (0)