Fixed clippy lints

Author: coderdan

src/crypto/attrs/flattened_protected_attributes.rs

@@ -97,11 +97,11 @@ impl FlattenedProtectedAttribute {
     }
 }
 
-impl Into<BytesWithDescriptor> for FlattenedProtectedAttribute {
-    fn into(self) -> BytesWithDescriptor {
-        BytesWithDescriptor {
-            bytes: self.plaintext.to_vec(),
-            descriptor: self.storage_descriptor(),
+impl From<FlattenedProtectedAttribute> for BytesWithDescriptor {
+    fn from(fpa: FlattenedProtectedAttribute) -> Self {
+        Self {
+            bytes: fpa.plaintext.to_vec(),
+            descriptor: fpa.storage_descriptor(),
         }
     }
 }
@@ -150,12 +150,12 @@ impl FlattenedAttrName {
     /// Parse a descriptor into a [FlattenedKey].
     pub(super) fn parse(descriptor: &str) -> Self {
         fn split_subkey(prefix: Option<String>, key: &str) -> FlattenedAttrName {
-            match key.split_once(".") {
+            match key.split_once('.') {
                 None => FlattenedAttrName::new(prefix, key),
                 Some((key, subkey)) => FlattenedAttrName::new(prefix, key).with_subkey(subkey),
             }
         }
-        match descriptor.split_once("/") {
+        match descriptor.split_once('/') {
             None => split_subkey(None, descriptor),
             Some((prefix, key)) => split_subkey(Some(prefix.to_string()), key),
         }

src/crypto/attrs/normalized_protected_attributes.rs

@@ -108,7 +108,6 @@ impl FromIterator<FlattenedProtectedAttribute> for NormalizedProtectedAttributes
                 }
                 acc
             })
-            .into()
     }
 }
 

src/crypto/sealed.rs

@@ -122,7 +122,6 @@ impl SealedTableEntry {
                 .chunks(chunk_size)
                 .into_iter()
                 .map(|fpa| fpa.into_iter().collect::<NormalizedProtectedAttributes>())
-                .into_iter()
                 .zip_eq(unprotected_items.into_iter())
                 .map(|(fpa, unprotected)| Ok(Unsealed::new_from_parts(fpa, unprotected)))
                 .collect()

src/encrypted_table/table_attribute.rs

@@ -44,8 +44,7 @@ impl TableAttribute {
             EncryptedRecord::from_slice(&s[..])
                 .map_err(SealError::from)
                 .and_then(|record| {
-                     // FIXME: Re-enable this check
-                    if true || record.descriptor == descriptor {
+                    if record.descriptor == descriptor {
                         Ok(record)
                     } else {
                         Err(SealError::AssertionFailed(format!(