Merge pull request #281 from cipherstash/fix/v3-sem-coderabbit-findings

fix(v3/sem): address CodeRabbit findings (hmac_256 inlining, ORE casing, fixture comment)

Author: tobyhede

src/v3/sem/hmac_256/functions.sql

@@ -33,10 +33,8 @@ $$;
 --! @return boolean True if 'hm' field is present and non-null
 CREATE FUNCTION eql_v3.has_hmac_256(val jsonb)
   RETURNS boolean
+  LANGUAGE sql
   IMMUTABLE STRICT PARALLEL SAFE
-  SET search_path = pg_catalog, extensions, public
 AS $$
-  BEGIN
-    RETURN val ->> 'hm' IS NOT NULL;
-  END;
-$$ LANGUAGE plpgsql;
+  SELECT (val ->> 'hm') IS NOT NULL
+$$;

src/v3/sem/ore_block_u64_8_256/functions.sql

@@ -132,7 +132,7 @@ AS $$
     FOR block IN 0..7 LOOP
       IF
         substr(a.bytes, 1 + block, 1) != substr(b.bytes, 1 + block, 1)
-        OR substr(a.bytes, 9 + left_block_size * block, left_block_size) != substr(b.bytes, 9 + left_block_size * BLOCK, left_block_size)
+        OR substr(a.bytes, 9 + left_block_size * block, left_block_size) != substr(b.bytes, 9 + left_block_size * block, left_block_size)
       THEN
         IF eq THEN
           unequal_block := block;

tests/sqlx/fixtures/match_data.sql

@@ -4,7 +4,7 @@
 -- Tests encrypted-to-encrypted matching using bloom filter indexes
 --
 -- Plaintext structure: {"hello": "world", "n": N}
--- where N is 10, 20, or 30 for records 1, 2, 3
+-- where N is 1, 2, or 3 for records 1, 2, 3
 
 -- Create table for LIKE operator tests
 DROP TABLE IF EXISTS encrypted CASCADE;